Skip to content

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Oct 20, 2025

fixes #14828

@camc314 camc314 marked this pull request as ready for review October 20, 2025 21:41
Copilot AI review requested due to automatic review settings October 20, 2025 21:41
@camc314 camc314 self-assigned this Oct 20, 2025
Copy link
Contributor Author

camc314 commented Oct 20, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a test case to the no_fallthrough linter rule to verify correct handling of switch statements with logical expressions in JSX contexts. The test addresses issue #14828.

  • Adds a single passing test case that validates fallthrough detection works correctly when switch cases contain logical operators (&&) within a JSX map callback

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot added A-linter Area - Linter C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Oct 20, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 20, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the c/10-20-test_linter_no-fallthrough_add_another_test_case_with_logical_expr branch from e652918 to a64180e Compare October 20, 2025 21:45
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 20, 2025

CodSpeed Performance Report

Merging #14832 will not alter performance

Comparing c/10-20-test_linter_no-fallthrough_add_another_test_case_with_logical_expr (a64180e) with main (b8f8ce5)1

Summary

✅ 4 untouched
⏩ 33 skipped2

Footnotes

  1. No successful run was found on main (a64180e) during the generation of this report, so b8f8ce5 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@graphite-app graphite-app bot merged commit a64180e into main Oct 20, 2025
20 checks passed
@graphite-app graphite-app bot deleted the c/10-20-test_linter_no-fallthrough_add_another_test_case_with_logical_expr branch October 20, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

linter: eslint/no-fallthrough rule incorrectly handles case statement with mapped array return value in jsx

2 participants