Skip to content

Conversation

@camchenry
Copy link
Member

@camchenry camchenry commented Oct 21, 2025

Same story as #14865.

Initial codspeed benchmark showed an anomalously large drop, though I'm not sure why. I'd expect a measurable but very small improvement.

Copy link
Member Author

camchenry commented Oct 21, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance labels Oct 21, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 21, 2025

CodSpeed Performance Report

Merging #14869 will improve performances by 6.74%

Comparing 10-21-perf_linter_no-unused-private-class-members_only_run_when_there_are_any_classes (243dd56) with 10-21-perf_linter_no-dupe-class-members_only_run_when_there_are_any_classes (77d9d99)

Summary

⚡ 1 improvement
✅ 3 untouched
⏩ 33 skipped1

Benchmarks breakdown

Mode Benchmark BASE HEAD Change
Simulation linter[RadixUIAdoptionSection.jsx] 793.1 µs 743 µs +6.74%

Footnotes

  1. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Oct 22, 2025
Copy link
Contributor

camc314 commented Oct 22, 2025

Merge activity

…are any classes (#14869)

Same story as #14865.

Initial codspeed benchmark showed an anomalously large drop, though I'm not sure why. I'd expect a measurable but very small improvement.
@graphite-app graphite-app bot force-pushed the 10-21-perf_linter_no-dupe-class-members_only_run_when_there_are_any_classes branch from 77d9d99 to 5493278 Compare October 22, 2025 08:20
@graphite-app graphite-app bot force-pushed the 10-21-perf_linter_no-unused-private-class-members_only_run_when_there_are_any_classes branch from 243dd56 to 11b055e Compare October 22, 2025 08:20
Base automatically changed from 10-21-perf_linter_no-dupe-class-members_only_run_when_there_are_any_classes to main October 22, 2025 08:24
@graphite-app graphite-app bot merged commit 11b055e into main Oct 22, 2025
21 checks passed
@graphite-app graphite-app bot deleted the 10-21-perf_linter_no-unused-private-class-members_only_run_when_there_are_any_classes branch October 22, 2025 08:24
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 22, 2025
@camc314 camc314 self-assigned this Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants