Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/oxc_linter/src/rules/jsdoc/check_tag_names.rs
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ impl Rule for CheckTagNames {
let config = &self.0;
let user_defined_tags = settings.list_user_defined_tag_names();

let is_dts = ctx.file_path().to_str().is_some_and(|p| p.ends_with(".d.ts"));
let is_dts = ctx.source_type().is_typescript_definition();
// NOTE: The original rule seems to check `declare` context by visiting AST nodes.
// https://github.com/gajus/eslint-plugin-jsdoc/blob/e343ab5b1efaa59b07c600138aee070b4083857e/src/rules/checkTagNames.js#L121
// But...
Expand Down
14 changes: 9 additions & 5 deletions crates/oxc_linter/src/rules/react/only_export_components.rs
Original file line number Diff line number Diff line change
Expand Up @@ -255,22 +255,26 @@ impl Rule for OnlyExportComponents {
}

fn should_run(&self, ctx: &crate::context::ContextHost) -> bool {
let Some(filename) = ctx.file_path().file_name().and_then(|s| s.to_str()) else {
return false;
};

let should_scan = {
let ext = ctx.file_extension();
matches!(ext, Some(e) if e.eq_ignore_ascii_case("tsx") || e.eq_ignore_ascii_case("jsx"))
|| (self.check_js && matches!(ext, Some(e) if e.eq_ignore_ascii_case("js")))
};

if !should_scan {
return false;
}

let Some(filename) = ctx.file_path().file_name().and_then(|s| s.to_str()) else {
return false;
};

let should_skip = filename.contains(".test.")
|| filename.contains(".spec.")
|| filename.contains(".cy.")
|| filename.contains(".stories.");

should_scan && !should_skip
!should_skip
}

fn run_once(&self, ctx: &LintContext<'_>) {
Expand Down
Loading