Skip to content

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Oct 22, 2025

@Dunqing or @Boshen do you mind reviewing + merging please.

Copy link
Contributor Author

camc314 commented Oct 22, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the A-ast Area - AST label Oct 22, 2025
@github-actions github-actions bot added the C-enhancement Category - New feature or request label Oct 22, 2025
@camc314 camc314 marked this pull request as ready for review October 22, 2025 17:50
Copilot AI review requested due to automatic review settings October 22, 2025 17:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new utility function is_inside_comment to check if a given position falls within any comment span. The function uses binary search for efficient O(log n) lookup performance.

Key Changes:

  • Added is_inside_comment function with comprehensive documentation
  • Implemented using binary search for optimal performance
  • Added test coverage for the new functionality

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
crates/oxc_ast/src/trivia.rs Implements the is_inside_comment function with binary search logic and adds unit tests
crates/oxc_ast/src/lib.rs Exports the new is_inside_comment function in the public API

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 22, 2025

CodSpeed Performance Report

Merging #14907 will not alter performance

Comparing c/10-22-feat_ast_add_is_inside_comment_method (7a66be5) with main (55ee962)

Summary

✅ 37 untouched

@camc314 camc314 force-pushed the c/10-22-feat_ast_add_is_inside_comment_method branch from 3b5400d to 7a66be5 Compare October 26, 2025 21:16
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Oct 26, 2025
Copy link
Contributor Author

camc314 commented Oct 26, 2025

Merge activity

@camc314 camc314 force-pushed the c/10-22-feat_ast_add_is_inside_comment_method branch from 7a66be5 to d658fbd Compare October 28, 2025 15:36
@Dunqing or @Boshen do you mind reviewing + merging please.
@graphite-app graphite-app bot force-pushed the c/10-22-feat_ast_add_is_inside_comment_method branch from d658fbd to b063e0e Compare October 28, 2025 15:42
@graphite-app graphite-app bot merged commit b063e0e into main Oct 28, 2025
20 checks passed
@graphite-app graphite-app bot deleted the c/10-22-feat_ast_add_is_inside_comment_method branch October 28, 2025 15:48
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants