-
-
Notifications
You must be signed in to change notification settings - Fork 711
feat(ast): add is_inside_comment method
#14907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ast): add is_inside_comment method
#14907
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new utility function is_inside_comment to check if a given position falls within any comment span. The function uses binary search for efficient O(log n) lookup performance.
Key Changes:
- Added
is_inside_commentfunction with comprehensive documentation - Implemented using binary search for optimal performance
- Added test coverage for the new functionality
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/oxc_ast/src/trivia.rs | Implements the is_inside_comment function with binary search logic and adds unit tests |
| crates/oxc_ast/src/lib.rs | Exports the new is_inside_comment function in the public API |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
CodSpeed Performance ReportMerging #14907 will not alter performanceComparing Summary
|
3b5400d to
7a66be5
Compare
Merge activity
|
7a66be5 to
d658fbd
Compare
d658fbd to
b063e0e
Compare

@Dunqing or @Boshen do you mind reviewing + merging please.