-
-
Notifications
You must be signed in to change notification settings - Fork 715
fix(parser): report err on missing function body in expression #14946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(parser): report err on missing function body in expression #14946
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a parser error handling issue where missing function bodies in function expressions were not being properly reported. The change ensures that function expressions always attempt to parse a body, even when the opening curly brace is missing, allowing the parser to generate an appropriate error message.
Key Changes:
- Modified the condition for parsing function bodies to include function expressions
- Function expressions now always attempt body parsing, enabling error reporting for missing bodies
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CodSpeed Performance ReportMerging #14946 will not alter performanceComparing Summary
Footnotes |
e16342b to
ede4926
Compare
ede4926 to
7389651
Compare
Merge activity
|
5ab2a5b to
a0c6162
Compare
7389651 to
9c63aaf
Compare
partially addresses #14944
9c63aaf to
384ea3c
Compare

partially addresses #14944