Skip to content

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Oct 25, 2025

partially addresses #14944

@github-actions github-actions bot added A-parser Area - Parser C-bug Category - Bug labels Oct 25, 2025
Copy link
Contributor Author

camc314 commented Oct 25, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 marked this pull request as ready for review October 25, 2025 14:49
Copilot AI review requested due to automatic review settings October 25, 2025 14:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a parser error handling issue where missing function bodies in function expressions were not being properly reported. The change ensures that function expressions always attempt to parse a body, even when the opening curly brace is missing, allowing the parser to generate an appropriate error message.

Key Changes:

  • Modified the condition for parsing function bodies to include function expressions
  • Function expressions now always attempt body parsing, enabling error reporting for missing bodies

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 25, 2025

CodSpeed Performance Report

Merging #14946 will not alter performance

Comparing c/10-25-fix_parser_report_err_on_missing_function_body_in_expression (7389651) with main (55ee962)1

Summary

✅ 37 untouched

Footnotes

  1. No successful run was found on c/10-26-chore_tasks_transform-conformance_update_snapshot (5ab2a5b) during the generation of this report, so main (55ee962) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@camc314 camc314 force-pushed the c/10-25-fix_parser_report_err_on_missing_function_body_in_expression branch from e16342b to ede4926 Compare October 26, 2025 20:47
@camc314 camc314 changed the base branch from main to graphite-base/14946 October 26, 2025 21:05
@camc314 camc314 force-pushed the c/10-25-fix_parser_report_err_on_missing_function_body_in_expression branch from ede4926 to 7389651 Compare October 26, 2025 21:05
@camc314 camc314 changed the base branch from graphite-base/14946 to c/10-26-chore_tasks_transform-conformance_update_snapshot October 26, 2025 21:05
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Oct 27, 2025
Copy link
Member

Boshen commented Oct 27, 2025

Merge activity

@graphite-app graphite-app bot changed the base branch from c/10-26-chore_tasks_transform-conformance_update_snapshot to graphite-base/14946 October 27, 2025 09:00
@camc314 camc314 force-pushed the graphite-base/14946 branch from 5ab2a5b to a0c6162 Compare October 27, 2025 10:56
@camc314 camc314 force-pushed the c/10-25-fix_parser_report_err_on_missing_function_body_in_expression branch from 7389651 to 9c63aaf Compare October 27, 2025 10:56
@camc314 camc314 changed the base branch from graphite-base/14946 to main October 27, 2025 10:57
@graphite-app graphite-app bot force-pushed the c/10-25-fix_parser_report_err_on_missing_function_body_in_expression branch from 9c63aaf to 384ea3c Compare October 27, 2025 11:04
@graphite-app graphite-app bot merged commit 384ea3c into main Oct 27, 2025
21 checks passed
@graphite-app graphite-app bot deleted the c/10-25-fix_parser_report_err_on_missing_function_body_in_expression branch October 27, 2025 11:09
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-parser Area - Parser C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants