-
-
Notifications
You must be signed in to change notification settings - Fork 714
fix(tasks/prettier_conformance): Skip tests which cannot parse #15025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tasks/prettier_conformance): Skip tests which cannot parse #15025
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements automatic skipping of tests that fail to parse, eliminating the need to manually maintain an ignore list for tests with unsupported syntax (e.g., stage 2, 3 features). When the parser encounters a syntax error, the test is now silently skipped rather than failing.
Key Changes:
- Modified
run_oxc_formatterto returnOption<String>and bail early when parsing errors occur - Removed explicit ignore list entries for stage 3 features that are now automatically skipped
- Updated test results showing improved pass rates (JS: 87.58% → 89.85%, TS: 88.96% → 89.80%)
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tasks/prettier_conformance/src/lib.rs | Updated run_oxc_formatter to return Option<String> and skip tests with parse errors; refactored calling code to handle the new return type |
| tasks/prettier_conformance/src/ignore_list.rs | Removed manual ignore entries for stage 3 features that are now automatically skipped |
| tasks/prettier_conformance/snapshots/prettier.ts.snap.md | Updated snapshot showing improved TypeScript test pass rate |
| tasks/prettier_conformance/snapshots/prettier.js.snap.md | Updated snapshot showing improved JavaScript test pass rate |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
d27f0fa to
4acb87b
Compare
4acb87b to
3259e7b
Compare
Merge activity
|
If the parser reports a syntax error, simply skip the test. `oxfmt` already reports error for this case. By this change, tests containing unsupported syntax such as stage 2, 3 will be automatically ignored. I'll add notes in the line comments to explain what they were like.
cd0ef1d to
5de99c2
Compare
25ddc9d to
daead30
Compare

If the parser reports a syntax error, simply skip the test.
oxfmtalready reports error for this case.By this change, tests containing unsupported syntax such as stage 2, 3 will be automatically ignored.
I'll add notes in the line comments to explain what they were like.