-
-
Notifications
You must be signed in to change notification settings - Fork 715
refactor(regular_expression): Improve initizalizing state #15045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(regular_expression): Improve initizalizing state #15045
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the duplicate named capturing group detection in regular expression parsing. The changes replace a complex post-processing approach with a cleaner, more maintainable algorithm that tracks alternative paths during parsing.
- Introduced
AlternativeTrackerto track nesting depth and alternative branches in real-time - Replaced
SimpleUnitenum and deferred duplicate checking with immediate validation during parsing - Added
NamedGroupInfostruct to store named group metadata including alternative paths
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CodSpeed Performance ReportMerging #15045 will not alter performanceComparing Summary
|
3ba3eb4 to
1b59a0c
Compare
Merge activity
|
1b59a0c to
561b743
Compare

Fixes #6358