Skip to content

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Oct 29, 2025

This PR adds handling for direct eval. It still ignores the fact that variable declarations inside direct eval can leak outside of it in non-strict mode. But I think that's fine as it's really edge case and is clearly written in the assumptions.

close #8372

@github-actions github-actions bot added the A-minifier Area - Minifier label Oct 29, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-enhancement Category - New feature or request label Oct 29, 2025
@sapphi-red sapphi-red force-pushed the 10-30-feat_minifier_handle_direct_eval_calls branch 2 times, most recently from caecbc8 to a8310c4 Compare October 29, 2025 16:04
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 29, 2025

CodSpeed Performance Report

Merging #15067 will not alter performance

Comparing 10-30-feat_minifier_handle_direct_eval_calls (13a33a3) with main (206b519)

Summary

✅ 33 untouched
⏩ 4 skipped1

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@sapphi-red sapphi-red force-pushed the 10-30-feat_minifier_handle_direct_eval_calls branch from a8310c4 to 13a33a3 Compare October 29, 2025 16:15
@sapphi-red sapphi-red marked this pull request as ready for review October 29, 2025 16:24
Copilot AI review requested due to automatic review settings October 29, 2025 16:24
@sapphi-red sapphi-red requested review from Boshen and removed request for Copilot October 29, 2025 16:25
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Oct 30, 2025
Copy link
Member

Boshen commented Oct 30, 2025

Merge activity

This PR adds handling for direct eval. It still ignores the fact that variable declarations inside direct eval can leak outside of it in non-strict mode. But I think that's fine as it's really edge case and is clearly written in the assumptions.

close #8372
Copilot AI review requested due to automatic review settings October 30, 2025 02:15
@graphite-app graphite-app bot force-pushed the 10-30-feat_minifier_handle_direct_eval_calls branch from 13a33a3 to c51c036 Compare October 30, 2025 02:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@graphite-app graphite-app bot merged commit c51c036 into main Oct 30, 2025
20 checks passed
@graphite-app graphite-app bot deleted the 10-30-feat_minifier_handle_direct_eval_calls branch October 30, 2025 02:20
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-minifier Area - Minifier C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

semantics: references created by direct eval in non-strict mode is not respected

3 participants