fix(ci): Correct boolean comparison in check-version action #15105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the version check action to fix a type comparison issue in the static-checking conditional. The change modifies how the diff-search boolean input is evaluated.
- Changed the
static-checkingcondition from comparing against booleanfalseto comparing against string'true'
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
leaysgur
force-pushed
the
10-30-fix_ci_correct_boolean_comparison_in_check-version_action
branch
from
253e57c to
0077c21
Compare
leaysgur
force-pushed
the
10-30-fix_ci_correct_boolean_comparison_in_check-version_action
branch
from
0077c21 to
20a52a6
Compare
Boshen
deleted the
10-30-fix_ci_correct_boolean_comparison_in_check-version_action
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
inputs.diff-search == falsecomparison always evaluated tofalsebecause composite action inputs are strings, not booleans.This caused
static-checkingto be set to an empty string instead of'localIsNew', making version-check fall back to commit history search mode and fail to detect version changes.