Skip to content

Conversation

@lilnasy
Copy link
Contributor

@lilnasy lilnasy commented Nov 1, 2025

Copilot AI review requested due to automatic review settings November 1, 2025 21:56
@lilnasy lilnasy requested a review from camc314 as a code owner November 1, 2025 21:56
@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI C-bug Category - Bug labels Nov 1, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a patch for the @typescript-eslint/scope-manager package (version 8.46.2) to fix issues with implicit lib variable handling in the scope analysis system. The patch makes the isTypeVariable and isValueVariable properties mutable and ensures implicit lib variables are always resolved statically.

Key changes:

  • Configures pnpm to apply a patch to @typescript-eslint/scope-manager@8.46.2
  • Creates a patch file that modifies how implicit lib variables are handled in scope resolution
  • Updates the lock file to reference the patched version of the dependency

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
pnpm-workspace.yaml Adds patchedDependencies configuration pointing to the scope-manager patch file
pnpm-lock.yaml Records the patch hash and path, updates dependency version references to include patch hash
apps/oxlint/patches/@typescript-eslint__scope-manager.patch Contains the actual patch that modifies ImplicitLibVariable handling in the scope-manager package
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lilnasy lilnasy force-pushed the fix/linter/patch-typescript-eslint-scope-manager branch from 5f481eb to 4367484 Compare November 1, 2025 22:02
@lilnasy lilnasy force-pushed the fix/linter/patch-typescript-eslint-scope-manager branch from 4367484 to 40b74cf Compare November 1, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant