feat(parser): improve error message for missing closing tokens #15269
+589
−231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #15269 will not alter performanceComparing Summary
|
sapphi-red
force-pushed
the
11-03-feat_parser_improve_error_message_for_missing_conditional_alternative
branch
from
95550fb to
d28a78e
Compare
sapphi-red
force-pushed
the
11-03-feat_parser_improve_error_message_for_missing_closing_tokens
branch
from
e580442 to
d067399
Compare
Member
Merge activity
|
Improves error message for imbalanced tokens. ``` × Expected `,` or `]` but found `const` ╭─[misc/fail/imbalanced-array-expr.js:2:1] 1 │ const foo = [0, 1 · ┬ · ╰── Opened here 2 │ const bar = 2 · ──┬── · ╰── `,` or `]` expected ╰──── ``` The error message for this case was: ``` x Expected `,` but found `const` ,-[:2:1] 1 | const foo = [0,1 2 | const bar = 2 : ^^|^^ : `-- `,` expected `---- ``` This change makes it clear why the parser is expecting `,` and also tell that it can be fixed by adding the closing token somewhere.
graphite-app
bot
force-pushed
the
11-03-feat_parser_improve_error_message_for_missing_conditional_alternative
branch
from
d28a78e to
2ef8f01
Compare
graphite-app
bot
force-pushed
the
11-03-feat_parser_improve_error_message_for_missing_closing_tokens
branch
from
d067399 to
d4f6545
Compare
Base automatically changed from
11-03-feat_parser_improve_error_message_for_missing_conditional_alternative
to
main
November 4, 2025 13:18
graphite-app
bot
deleted the
11-03-feat_parser_improve_error_message_for_missing_closing_tokens
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves error message for imbalanced tokens.
The error message for this case was:
This change makes it clear why the parser is expecting
,and also tell that it can be fixed by adding the closing token somewhere.