feat(allocator): add Address::from_ref method
#15318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-linter
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #15318 will not alter performanceComparing Summary
Footnotes |
Member
Author
Merge activity
|
We are generally using `Address::from_ptr` to get the `Address` of a reference, relying on `&T` dereferencing to `*const T`. Add an explicit method `Address::from_ref` for this, and document its pitfalls (which are the same as `Address::from_ptr`). Update all uses of `from_ptr` to `from_ref`, except those in `oxc_traverse`, where creating references is not possible due to aliasing rules. Once that problem is solved, we can make `from_ptr` take a `NonNull<T>` instead of `*const T`, and make `Address`'s inner type a `NonZeroUsize`, which will give `Address` a niche, and reduce `Option<Address>` from 16 bytes to 8.
graphite-app
bot
force-pushed
the
11-05-chore_deps_bump_msrv_to_1.89.0
branch
from
971f718 to
a64cf11
Compare
graphite-app
bot
force-pushed
the
11-05-feat_allocator_add_address_from_ref_method
branch
from
52cf6a3 to
8d69661
Compare
graphite-app
bot
deleted the
11-05-feat_allocator_add_address_from_ref_method
branch
This was referenced Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are generally using
Address::from_ptrto get theAddressof a reference, relying on&Tdereferencing to*const T.Add an explicit method
Address::from_reffor this, and document its pitfalls (which are the same asAddress::from_ptr).Update all uses of
from_ptrtofrom_ref, except those inoxc_traverse, where creating references is not possible due to aliasing rules.Once that problem is solved, we can make
from_ptrtake aNonNull<T>instead of*const T, and makeAddress's inner type aNonZeroUsize, which will giveAddressa niche, and reduceOption<Address>from 16 bytes to 8.