Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Nov 7, 2025

Small optimization to linter plugins JS code. Use the cheapest for loops, rather than for of, and avoid accessing length on each turn of the loop.

Copy link
Member Author

overlookmotel commented Nov 7, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI C-performance Category - Solution not expected to change functional behavior, only performance labels Nov 7, 2025
@overlookmotel overlookmotel force-pushed the 11-07-fix_linter_plugins_replace_context_class branch from 1f05a07 to 5dbea0c Compare November 7, 2025 19:25
@overlookmotel overlookmotel force-pushed the 11-07-perf_linter_plugins_optimize_loops branch from 1efa600 to d664a3d Compare November 7, 2025 19:25
@overlookmotel overlookmotel force-pushed the 11-07-fix_linter_plugins_replace_context_class branch from 5dbea0c to 80df3ec Compare November 7, 2025 19:32
@overlookmotel overlookmotel force-pushed the 11-07-perf_linter_plugins_optimize_loops branch from d664a3d to 3564a52 Compare November 7, 2025 19:32
@overlookmotel overlookmotel force-pushed the 11-07-fix_linter_plugins_replace_context_class branch from 80df3ec to 34fa651 Compare November 7, 2025 19:34
@overlookmotel overlookmotel force-pushed the 11-07-perf_linter_plugins_optimize_loops branch from 3564a52 to e702e36 Compare November 7, 2025 19:34
@overlookmotel overlookmotel marked this pull request as ready for review November 7, 2025 19:42
@overlookmotel overlookmotel self-assigned this Nov 7, 2025
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Nov 7, 2025
Copy link
Member Author

overlookmotel commented Nov 7, 2025

Merge activity

Small optimization to linter plugins JS code. Use the cheapest `for` loops, rather than `for of`, and avoid accessing `length` on each turn of the loop.
@graphite-app graphite-app bot force-pushed the 11-07-fix_linter_plugins_replace_context_class branch from 34fa651 to a17ca32 Compare November 7, 2025 19:44
@graphite-app graphite-app bot force-pushed the 11-07-perf_linter_plugins_optimize_loops branch from e702e36 to 3c57291 Compare November 7, 2025 19:45
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 7, 2025
Base automatically changed from 11-07-fix_linter_plugins_replace_context_class to main November 7, 2025 19:50
@graphite-app graphite-app bot merged commit 3c57291 into main Nov 7, 2025
19 checks passed
@graphite-app graphite-app bot deleted the 11-07-perf_linter_plugins_optimize_loops branch November 7, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants