Skip to content

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Nov 8, 2025

Improved the error file collection logic to pick up files like importMeta(module=system,target=es5).errors.txt​. Also added support for preserveconstenums​ and usedefineforclassfields.

Copy link
Member Author

sapphi-red commented Nov 8, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-test Category - Testing. Code is missing test cases, or a PR is adding them label Nov 8, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 8, 2025

CodSpeed Performance Report

Merging #15496 will not alter performance

Comparing 11-09-test_tasks_coverage_typescript_collect_more_error_files (b3fb231) with main (e81587d)

Summary

✅ 37 untouched

@sapphi-red sapphi-red changed the base branch from 11-09-fix_semantic_allow_reserved_keywords_in_typescript_ambient_contexts to graphite-base/15496 November 8, 2025 17:31
@sapphi-red sapphi-red force-pushed the 11-09-test_tasks_coverage_typescript_collect_more_error_files branch from aecd62b to 6d6dd71 Compare November 8, 2025 17:31
@sapphi-red sapphi-red changed the base branch from graphite-base/15496 to 11-09-test_coverage_typescript_parse_as_module_if_export_is_present November 8, 2025 17:31
@sapphi-red sapphi-red requested review from Boshen and leaysgur November 8, 2025 17:35
@sapphi-red sapphi-red marked this pull request as ready for review November 8, 2025 17:35
@sapphi-red sapphi-red force-pushed the 11-09-test_tasks_coverage_typescript_collect_more_error_files branch 2 times, most recently from a0895a4 to 103d98d Compare November 10, 2025 01:24
@sapphi-red sapphi-red force-pushed the 11-09-test_coverage_typescript_parse_as_module_if_export_is_present branch from 4ebab5f to 3b06541 Compare November 10, 2025 01:24
@sapphi-red sapphi-red force-pushed the 11-09-test_tasks_coverage_typescript_collect_more_error_files branch from 103d98d to c0ba508 Compare November 10, 2025 01:59
@sapphi-red sapphi-red force-pushed the 11-09-test_coverage_typescript_parse_as_module_if_export_is_present branch from 3b06541 to 2846641 Compare November 10, 2025 01:59
@graphite-app graphite-app bot force-pushed the 11-09-test_coverage_typescript_parse_as_module_if_export_is_present branch 2 times, most recently from 8435e05 to f9d94b6 Compare November 10, 2025 02:13
@graphite-app graphite-app bot force-pushed the 11-09-test_tasks_coverage_typescript_collect_more_error_files branch from c0ba508 to c8c7da7 Compare November 10, 2025 02:13
@sapphi-red sapphi-red changed the base branch from 11-09-test_coverage_typescript_parse_as_module_if_export_is_present to graphite-base/15496 November 10, 2025 04:24
@sapphi-red sapphi-red force-pushed the 11-09-test_tasks_coverage_typescript_collect_more_error_files branch from c8c7da7 to b3fb231 Compare November 10, 2025 04:24
@sapphi-red sapphi-red changed the base branch from graphite-base/15496 to main November 10, 2025 04:24
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Nov 10, 2025
Copy link
Member

Boshen commented Nov 10, 2025

Merge activity

Improved the error file collection logic to pick up files like `importMeta(module=system,target=es5).errors.txt`​. Also added support for `preserveconstenums`​ and `usedefineforclassfields`.
Copilot AI review requested due to automatic review settings November 10, 2025 04:36
@graphite-app graphite-app bot force-pushed the 11-09-test_tasks_coverage_typescript_collect_more_error_files branch from b3fb231 to ee035b4 Compare November 10, 2025 04:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@graphite-app graphite-app bot merged commit ee035b4 into main Nov 10, 2025
21 checks passed
@graphite-app graphite-app bot deleted the 11-09-test_tasks_coverage_typescript_collect_more_error_files branch November 10, 2025 04:42
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants