Skip to content

test(linter/plugins): remove dprint-ignore-file comments from test fixtures #15593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 11, 2025
Merged

test(linter/plugins): remove dprint-ignore-file comments from test fixtures #15593

merged 1 commit into from
Nov 11, 2025

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Nov 11, 2025 •
edited
Loading

We don't use dprint any more to format JS/TS. So remove defunct // dprint-ignore-file comments from test fixtures.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Nov 11, 2025
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Nov 11, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review November 11, 2025 12:57
Copilot AI review requested due to automatic review settings November 11, 2025 12:57
@overlookmotel overlookmotel self-assigned this Nov 11, 2025
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Nov 11, 2025
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Nov 11, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Nov 11, 12:58 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 11, 3:12 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 11, 3:16 PM UTC: overlookmotel added this pull request to the Graphite merge queue.
  • Nov 11, 3:22 PM UTC: Merged by the Graphite merge queue.

@overlookmotel overlookmotel marked this pull request as draft November 11, 2025 12:58
Copilot finished reviewing on behalf of overlookmotel November 11, 2025 12:59
Copilot AI reviewed Nov 11, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes defunct // dprint-ignore-file comments from test fixtures, as dprint is no longer used for formatting JavaScript/TypeScript files in the project.

Key Changes

  • Removed // dprint-ignore-file comments from two test fixture files
  • Updated corresponding snapshot files to reflect the correct line numbers and character offsets after the comment removal

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
apps/oxlint/test/fixtures/estree/files/index.ts Removed the defunct // dprint-ignore-file comment (1 line removed)
apps/oxlint/test/fixtures/estree/output.snap.md Updated snapshot with corrected line numbers and character positions after comment removal
apps/oxlint/test/fixtures/custom_plugin_disable_directives/files/index.js Removed the defunct // dprint-ignore-file comment and blank line (2 lines removed)
apps/oxlint/test/fixtures/custom_plugin_disable_directives/output.snap.md Updated snapshot with corrected line numbers after comment removal

The changes are consistent and correct. The snapshot updates accurately reflect the removal of the comments, with all line numbers and character offsets properly adjusted. No issues were found during the review.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@overlookmotel overlookmotel removed the 0-merge Merge with Graphite Merge Queue label Nov 11, 2025
@overlookmotel
Copy link
Member Author

overlookmotel commented Nov 11, 2025

Actually it'd be better to replace with an oxfmt equivalent (// oxfmt-ignore-file) to make sure these files don't get formatted. If they did, these tests wouldn't test what they're meant to!

But I don't know if oxfmt supports such comments...

@overlookmotel overlookmotel marked this pull request as ready for review November 11, 2025 14:49
@overlookmotel overlookmotel force-pushed the 11-11-test_linter_plugins_remove_dprint-ignore-file_comments_from_test_fixtures branch from 5e5d2af to a881b4f Compare November 11, 2025 15:10
@overlookmotel
Copy link
Member Author

overlookmotel commented Nov 11, 2025

Dunqing has advised no such oxfmt-ignore comment exists. So we'll have to go with it as is.

I've added assertions to one of the tests which will throw if the fixture file gets formatted by accident.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Nov 11, 2025
@overlookmotel
test(linter/plugins): remove dprint-ignore-file comments from test …
3eefa15 
…fixtures (#15593)

We don't use `dprint` any more to format JS/TS. So remove defunct `// dprint-ignore-file` comments from test fixtures.
@graphite-app graphite-app bot force-pushed the 11-11-test_linter_plugins_remove_dprint-ignore-file_comments_from_test_fixtures branch from a881b4f to 3eefa15 Compare November 11, 2025 15:17
@graphite-app graphite-app bot merged commit 3eefa15 into main Nov 11, 2025
18 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 11, 2025
@graphite-app graphite-app bot deleted the 11-11-test_linter_plugins_remove_dprint-ignore-file_comments_from_test_fixtures branch November 11, 2025 15:22
@overlookmotel overlookmotel mentioned this pull request Nov 11, 2025
Merged
graphite-app bot pushed a commit that referenced this pull request Nov 11, 2025
@overlookmotel
style(linter/plugins): use prettier-ignore in test fixtures (#15602)
74033bd 
Follow-on after #15593 and #15600. Use `// prettier-ignore` comments in test fixture files to prevent them being formatted, where formatting would break the test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@camc314 camc314 Awaiting requested review from camc314 camc314 is a code owner

Assignees

@overlookmotel overlookmotel

Labels

A-cli Area - CLI A-linter Area - Linter C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel