Skip to content

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Nov 18, 2025

No description provided.

Copilot AI review requested due to automatic review settings November 18, 2025 01:28
Copy link
Member Author

Boshen commented Nov 18, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a cargo check command for the wasm32-wasip1-threads target to verify compilation before running the NAPI builds in the CI workflow.

  • Adds early validation that the codebase compiles for the wasm32-wasip1-threads target
  • Provides faster feedback if there are compilation issues before attempting the more time-consuming napi build steps

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Boshen Boshen changed the title ci: add cargo check --target wasm32-wasip1-threads to wasi test chore(ci): add cargo check --target wasm32-wasip1-threads to wasi test Nov 18, 2025
@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Nov 18, 2025
@Boshen Boshen self-assigned this Nov 18, 2025
@Dunqing
Copy link
Member

Dunqing commented Nov 18, 2025

Should we narrow the command to the oxc_formatter only? For speed reasons.

@Boshen Boshen changed the title chore(ci): add cargo check --target wasm32-wasip1-threads to wasi test chore(ci): check playground in wasi test Nov 18, 2025
@Boshen Boshen force-pushed the 11-18-ci_add_cargo_check_--target_wasm32-wasip1-threads_to_wasi_test branch from 08a4ebf to 6ee4ad7 Compare November 18, 2025 06:03
@Boshen Boshen force-pushed the 11-18-ci_add_cargo_check_--target_wasm32-wasip1-threads_to_wasi_test branch 2 times, most recently from 18e5222 to b47f3e5 Compare November 18, 2025 06:28
@Dunqing Dunqing force-pushed the 11-18-ci_add_cargo_check_--target_wasm32-wasip1-threads_to_wasi_test branch from b47f3e5 to e693823 Compare November 19, 2025 05:42
@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Nov 19, 2025
Copy link
Member

Dunqing commented Nov 19, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 11-18-ci_add_cargo_check_--target_wasm32-wasip1-threads_to_wasi_test branch from e693823 to ab00462 Compare November 19, 2025 05:55
@graphite-app graphite-app bot merged commit ab00462 into main Nov 19, 2025
20 checks passed
@graphite-app graphite-app bot deleted the 11-18-ci_add_cargo_check_--target_wasm32-wasip1-threads_to_wasi_test branch November 19, 2025 06:01
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 19, 2025
taearls pushed a commit to taearls/oxc that referenced this pull request Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants