Skip to content

Conversation

@leaysgur
Copy link
Member

Just enhancement, will merge after CI.

Copilot AI review requested due to automatic review settings November 20, 2025 01:51
@github-actions github-actions bot added A-cli Area - CLI A-formatter Area - Formatter labels Nov 20, 2025
@leaysgur leaysgur changed the title chore(oxfmt): Use strict: true for TS code chore(oxfmt): Use strict: true for TS code Nov 20, 2025
@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Nov 20, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot finished reviewing on behalf of leaysgur November 20, 2025 01:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables TypeScript's strict mode for the oxfmt application, replacing the less comprehensive noImplicitAny option. The strict mode includes additional type safety checks such as strictNullChecks, strictFunctionTypes, strictBindCallApply, and others.

  • Upgraded TypeScript configuration from noImplicitAny: true to strict: true
  • Added nullish coalescing operator to handle potentially undefined exitCode from execa

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
apps/oxfmt/tsconfig.json Replaced noImplicitAny: true with strict: true to enable comprehensive TypeScript strict type checking
apps/oxfmt/test/utils.ts Added nullish coalescing operator (?? -1) to handle potentially undefined exitCode from execa, required by strict mode's strictNullChecks

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@leaysgur leaysgur merged commit acf9637 into main Nov 20, 2025
25 checks passed
@leaysgur leaysgur deleted the 11-20-chore_oxfmt_use_strict_true_for_ts_code branch November 20, 2025 01:57
Copilot AI pushed a commit that referenced this pull request Nov 21, 2025
Just enhancement, will merge after CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-formatter Area - Formatter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants