build(linter/plugins): build either release or debug version, not both #15949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Copilot finished reviewing on behalf of
overlookmotel
November 21, 2025 16:43
Contributor
There was a problem hiding this comment.
Pull request overview
This PR consolidates the Oxlint build process to generate either a release or debug build based on the DEBUG environment variable, eliminating the need to produce both builds simultaneously. When DEBUG=true, the build includes debug assertions for testing; otherwise, it produces an optimized release build with assertions removed.
Key Changes
- Unified build configuration using a
DEBUGenvironment variable to control assertion inclusion - Updated test scripts to use the single
dist/output directory instead of a separatedebug/directory - Removed duplicate build artifacts and unnecessary file operations from the build script
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| apps/oxlint/tsdown.config.ts | Consolidated two build configs into one controlled by DEBUG env var; moved ASSERTS_PATH into plugin function |
| apps/oxlint/test/e2e.test.ts | Updated CLI path from debug/cli.js to dist/cli.js |
| apps/oxlint/scripts/build.ts | Removed debug directory operations (cli.d.ts deletion and .node file copying) |
| apps/oxlint/package.json | Updated build-dev and build-test scripts to set DEBUG=true; changed import path to dist/ |
| apps/oxlint/.gitignore | Removed /debug/ directory from gitignore |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
overlookmotel
force-pushed
the
11-21-build_linter_plugins_build_either_release_or_debug_version_not_both
branch
from
9fe5682 to
5004d5f
Compare
camc314
approved these changes
Nov 23, 2025
Contributor
Merge activity
|
#15949) #15921 added a debug build for Oxlint, and various PRs since have tweaked it. However, I now realize there's little point in generating *both* a release build and debug build. Just create one build, and use env var `DEBUG` to control whether it has debug assertions included in it or not. `pnpm run build` produces release build with no debug assertions, `pnpm run build-test` includes the asserts. I've verified that both do what they're meant to.
graphite-app
bot
force-pushed
the
11-21-build_linter_plugins_build_either_release_or_debug_version_not_both
branch
from
5004d5f to
80fe39d
Compare
graphite-app
bot
deleted the
11-21-build_linter_plugins_build_either_release_or_debug_version_not_both
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#15921 added a debug build for Oxlint, and various PRs since have tweaked it. However, I now realize there's little point in generating both a release build and debug build.
Just create one build, and use env var
DEBUGto control whether it has debug assertions included in it or not.pnpm run buildproduces release build with no debug assertions,pnpm run build-testincludes the asserts. I've verified that both do what they're meant to.