-
-
Notifications
You must be signed in to change notification settings - Fork 735
feat(tasks/lint-rules): track rules with pending fixes in automated issues #15989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tasks/lint-rules): track rules with pending fixes in automated issues #15989
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
6a17791 to
49954eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds functionality to track and display linter rules that have pending auto-fixes in the automated GitHub tracking issues. The implementation scans rule files to detect the pending keyword in declare_oxc_lint! macro declarations and displays this information with a ⏳ emoji in the generated markdown.
Key changes:
- Added
readAllPendingFixRuleNames()to recursively scan Rust rule files and extract rules marked with pending fixes - Extended
RuleEntrytype and related functions to trackisPendingFixstatus - Updated markdown renderer to display pending fix counts and indicators
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tasks/lint_rules/src/oxlint-rules.mjs | Added readAllPendingFixRuleNames() function to scan rule files for pending fixes, added updatePendingFixStatus() to mark implemented rules with pending fixes, updated RuleEntry type to include isPendingFix field, and preserved isPendingFix status in plugin sync functions |
| tasks/lint_rules/src/markdown-renderer.mjs | Updated CounterView type to include isPendingFix count, modified renderCounters() to display pending fix statistics, updated renderRulesList() to show ⏳ emoji for pending fixes, and added pending fix counts to all counter objects |
| tasks/lint_rules/src/main.mjs | Imported and called updatePendingFixStatus() to populate pending fix data in the rule processing pipeline |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add functionality to detect and display linter rules that have pending auto-fixes in the automated GitHub tracking issues. - Add readAllPendingFixRuleNames() to scan rule files for `pending` keyword - Update RuleEntry type to include isPendingFix field - Add updatePendingFixStatus() to mark implemented rules with pending fixes - Update markdown renderer to show ⏳ emoji for pending fixes - Add pending fix counts to summary and table headers - Preserve isPendingFix status across plugin sync operations Resolves #15977
49954eb to
5c41c26
Compare
connorshea
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!

Add functionality to detect and display linter rules that have pending
auto-fixes in the automated GitHub tracking issues.
pendingkeywordFixes #15977