Skip to content

refactor(linter/plugins): move placeholder replacement into own function #16302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2025
Merged

refactor(linter/plugins): move placeholder replacement into own function #16302

merged 1 commit into from
Nov 30, 2025
+25 −12

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Nov 30, 2025 •
edited
Loading

Pure refactor. Move message placeholder replacement into its own function, so it can also be used by rule tester (#16206).

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI A-linter-plugins Area - Linter JS plugins C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Nov 30, 2025
This was referenced Nov 30, 2025
Merged
Merged
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Nov 30, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel mentioned this pull request Nov 30, 2025
Merged
@overlookmotel overlookmotel marked this pull request as ready for review November 30, 2025 19:06
Copilot AI review requested due to automatic review settings November 30, 2025 19:06
@overlookmotel overlookmotel self-assigned this Nov 30, 2025
@overlookmotel overlookmotel marked this pull request as draft November 30, 2025 19:07
Copilot finished reviewing on behalf of overlookmotel November 30, 2025 19:08
Copilot AI reviewed Nov 30, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR performs a clean refactoring that extracts placeholder replacement logic into a dedicated function to enable reuse by the rule tester (issue #16206). The refactoring introduces a new exported DiagnosticData type and consolidates the placeholder interpolation logic.

Key changes:

  • Extracted inline placeholder replacement code into a separate replacePlaceholders() helper function
  • Introduced and exported DiagnosticData type alias for Record<string, string | number>
  • Updated type references in DiagnosticBase and SuggestionBase to use the new type alias

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
apps/oxlint/src-js/plugins/report.ts Extracts placeholder replacement into replacePlaceholders() function; introduces and exports DiagnosticData type; updates type references to use the new type alias
apps/oxlint/src-js/index.ts Exports the new DiagnosticData type alongside existing Diagnostic and Suggestion types

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@overlookmotel overlookmotel force-pushed the 11-30-refactor_linter_plugins_move_placeholder_replacement_into_own_function branch from f0114a9 to 25da8e1 Compare November 30, 2025 23:16
@overlookmotel overlookmotel marked this pull request as ready for review November 30, 2025 23:17
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Nov 30, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 30, 2025 •
edited
Loading

Merge activity

@overlookmotel
refactor(linter/plugins): move placeholder replacement into own funct…
9de386d 
…ion (#16302)

Pure refactor. Move placeholder replacement into it's own function, so it can also be used by rule tester (#16206).
@graphite-app graphite-app bot force-pushed the 11-30-refactor_linter_plugins_move_placeholder_replacement_into_own_function branch from 25da8e1 to 9de386d Compare November 30, 2025 23:51
@graphite-app graphite-app bot merged commit 9de386d into main Nov 30, 2025
18 checks passed
@graphite-app graphite-app bot deleted the 11-30-refactor_linter_plugins_move_placeholder_replacement_into_own_function branch November 30, 2025 23:56
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@camc314 camc314 Awaiting requested review from camc314 camc314 is a code owner

Assignees

@overlookmotel overlookmotel

Labels

A-cli Area - CLI A-linter Area - Linter A-linter-plugins Area - Linter JS plugins C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel