Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): support read env from eslintrc #2130

Merged
merged 3 commits into from
Jan 26, 2024

Conversation

fi3ework
Copy link
Contributor

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI labels Jan 22, 2024
Copy link

codspeed-hq bot commented Jan 22, 2024

CodSpeed Performance Report

Merging #2130 will not alter performance

Comparing fi3ework:feat_env (f5a8665) with main (fc1592b)

Summary

✅ 17 untouched benchmarks

Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Godsend! Let's improve the global.json generation.

crates/oxc_linter/build.rs Outdated Show resolved Hide resolved
crates/oxc_linter/src/lib.rs Outdated Show resolved Hide resolved
tasks/envgen/Cargo.toml Outdated Show resolved Hide resolved
tasks/envgen/globals.json Outdated Show resolved Hide resolved
tasks/envgen/globals.json Outdated Show resolved Hide resolved
Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work!

@Boshen Boshen merged commit ee5b968 into oxc-project:main Jan 26, 2024
20 checks passed
@fi3ework fi3ework deleted the feat_env branch January 26, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Area - CLI A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug(linter): some global objects are not included
2 participants