-
-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use oxc's own graphical reporter for test snapshots #2241
Merged
Boshen
merged 1 commit into
oxc-project:main
from
maurice:fix/use-oxc-graphical-reporter-for-snapshots
Feb 1, 2024
Merged
Use oxc's own graphical reporter for test snapshots #2241
Boshen
merged 1 commit into
oxc-project:main
from
maurice:fix/use-oxc-graphical-reporter-for-snapshots
Feb 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were using ihe miette default, but given ours is a fork, and for example now prints slightly more relevant line- and column-numbers vs miette, we should dog-food our own have the tests tell us if/when the output changes.
CodSpeed Performance ReportMerging #2241 will not alter performanceComparing Summary
|
See #2242 |
This is much better!! Thank you so much! |
Boshen
pushed a commit
that referenced
this pull request
Feb 1, 2024
Improves diagnostic report source line- and column-number for **multiline annotations** Requires #2241
IWANABETHATGUY
pushed a commit
to IWANABETHATGUY/oxc
that referenced
this pull request
May 29, 2024
Fixes oxc-project#2217 Previously we were using the miette default, but given ours is a fork, and for example now prints slightly more relevant line- and column-numbers vs miette, we should dog-food our own have the tests tell us if/when the output changes. I did actually scan all the snapshot deltas and all look correct to me. One funny one I noticed was this ```diff diff --git a/crates/oxc_linter/src/snapshots/no_empty_file.snap b/crates/oxc_linter/src/snapshots/no_empty_file.snap index cfc53e1c..6f001fbd 100644 --- a/crates/oxc_linter/src/snapshots/no_empty_file.snap +++ b/crates/oxc_linter/src/snapshots/no_empty_file.snap @@ -2,6 +2,7 @@ source: crates/oxc_linter/src/tester.rs expression: no_empty_file --- + ⚠ eslint-plugin-unicorn(no-empty-file): Empty files are not allowed. ╭─[no_empty_file.tsx:1:1] ╰──── @@ -29,7 +30,7 @@ expression: no_empty_file help: Delete this file or add some code to it. ⚠ eslint-plugin-unicorn(no-empty-file): Empty files are not allowed. - ╭─[no_empty_file.tsx:1:1] + ╭─[no_empty_file.tsx:0:1] 0 │ · ▲ ╰──── @@ -149,4 +150,3 @@ expression: no_empty_file ╰──── help: Delete this file or add some code to it. - ``` ...which I suppose is technically correct but also a bit confusing perhaps? Should we make the line **minimum 1**? If so I can create another PR for that. There is a subtle change in whitespace too - each file gains a newline at the start but looses one at the end. My assumption is that oxc's reporter is adding a newline at the start of each report (compared to miette's), plus I removed the extra newline in `tester.rs` or else the snapshot diffs would have been even larger. Finally there are no changes to reports with *multi-line* annotations like this: ``` ⚠ typescript-eslint(ban-types): Prefer explicitly define the object shape ╭─[ban_types.tsx:1:1] 1 │ ╭─▶ const emptyObj: { 2 │ │ 3 │ ╰─▶ } = {foo: "bar"}; ╰──── help: This type means "any non-nullish value", which is slightly better than 'unknown', but it's still a broad type ``` Again I can create a separate PR to improve those and we should see snapshot diffs when I make that change 😄 I'd appreciate a quick review on this one if at all possible, given the high chance of conflict.
IWANABETHATGUY
pushed a commit
to IWANABETHATGUY/oxc
that referenced
this pull request
May 29, 2024
…ect#2242) Improves diagnostic report source line- and column-number for **multiline annotations** Requires oxc-project#2241
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2217
Previously we were using the miette default, but given ours is a fork, and for example now prints slightly more relevant line- and column-numbers vs miette, we should dog-food our own have the tests tell us if/when the output changes.
I did actually scan all the snapshot deltas and all look correct to me.
One funny one I noticed was this
...which I suppose is technically correct but also a bit confusing perhaps? Should we make the line minimum 1? If so I can create another PR for that.
There is a subtle change in whitespace too - each file gains a newline at the start but looses one at the end. My assumption is that oxc's reporter is adding a newline at the start of each report (compared to miette's), plus I removed the extra newline in
tester.rs
or else the snapshot diffs would have been even larger.Finally there are no changes to reports with multi-line annotations like this:
Again I can create a separate PR to improve those and we should see snapshot diffs when I make that change 😄
I'd appreciate a quick review on this one if at all possible, given the high chance of conflict.