Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): add missing typescript-eslint(_) prefix for some errors #2342

Conversation

maurice
Copy link
Contributor

@maurice maurice commented Feb 7, 2024

Running latest on one of my projects these warnings jumped out at me because they were "anonymous" vs the others.

This PR just adds the usual rule-name prefix to the errors where it was missing

@github-actions github-actions bot added the A-linter Area - Linter label Feb 7, 2024
Copy link

codspeed-hq bot commented Feb 7, 2024

CodSpeed Performance Report

Merging #2342 will not alter performance

Comparing maurice:fix/missing-rule-name-before-some-typescript-rule-errors (89ebd3b) with main (0bdecb5)

Summary

✅ 27 untouched benchmarks

@Boshen Boshen merged commit ebc08d4 into oxc-project:main Feb 8, 2024
20 checks passed
@Boshen
Copy link
Member

Boshen commented Feb 8, 2024

Thank you!

@maurice maurice deleted the fix/missing-rule-name-before-some-typescript-rule-errors branch February 8, 2024 08:19
IWANABETHATGUY pushed a commit to IWANABETHATGUY/oxc that referenced this pull request May 29, 2024
…xc-project#2342)

Running latest on one of my projects these warnings jumped out at me
because they were "anonymous" vs the others.

This PR just adds the usual rule-name prefix to the errors where it was
missing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants