fix(linter/jsx_a11y): Refactor jsx-a11y related utils and its usage #2389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #2389 will not alter performanceComparing Summary
|
leaysgur
changed the title
get_element_type utils
Boshen
approved these changes
Feb 13, 2024
IWANABETHATGUY
pushed a commit
to IWANABETHATGUY/oxc
that referenced
this pull request
May 29, 2024
…xc-project#2389) Fixes oxc-project#2360 To make `jsx-a11y/anchor-has-content` test pass, - [x] Use `utils::get_element_type(ctx, el)` in `utils::is_hidden_from_screen_reader` and `utils::object_has_accessible_child` - [x] `utils::object_has_accessible_child` should handle both `null` and `undefined` and on the way..., - [x] `utils::get_element_type` should be used only in `jsx_a11y/*` rules - [x] Use those utils everywhere(remove manual implementation)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2360
To make
jsx-a11y/anchor-has-contenttest pass,utils::get_element_type(ctx, el)inutils::is_hidden_from_screen_readerandutils::object_has_accessible_childutils::object_has_accessible_childshould handle bothnullandundefinedand on the way...,
utils::get_element_typeshould be used only injsx_a11y/*rules