linter: implement from_configuration for jsx-a11y anchor-is-valid #2425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #2425 will not alter performanceComparing Summary
|
yossydev
force-pushed
the
fix/jsx-a11y-anchor-is-valid
branch
3 times, most recently
from
b267c5c
to
e85e0ce
Compare
yossydev
force-pushed
the
fix/jsx-a11y-anchor-is-valid
branch
from
e85e0ce
to
25c1ad8
Compare
camc314
approved these changes
Feb 18, 2024
camc314
reviewed
Feb 18, 2024
|
Let's merge first. |
IWANABETHATGUY
pushed a commit
to IWANABETHATGUY/oxc
that referenced
this pull request
May 29, 2024
…c-project#2425) - fix: oxc-project#2361 Created the `from_configuration` function to recognize links written during testing as valid. This function takes a JSON configuration and generates an `AnchorIsValidConfig` object, which determines whether specific hrefs are valid. This change allows us to easily specify valid hrefs in our tests, ensuring that our link validation logic works as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from_configuration()forjsx_a11y/anchor-is-valid#2361Created the
from_configurationfunction to recognize links written during testing as valid. This function takes a JSON configuration and generates anAnchorIsValidConfigobject, which determines whether specific hrefs are valid. This change allows us to easily specify valid hrefs in our tests, ensuring that our link validation logic works as expected.