feat(linter): eslint no-nonoctal-decimal-escape #2428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tudorbarbu
force-pushed
the
eslint-no-nonoctal-decimal-escape
branch
from
8f22750
to
3302d16
Compare
CodSpeed Performance ReportMerging #2428 will not alter performanceComparing Summary
|
Boshen
reviewed
Feb 19, 2024
crates/oxc_linter/src/rules/eslint/no_nonoctal_decimal_escape.rs
Outdated
Show resolved
Hide resolved
Boshen
approved these changes
Feb 21, 2024
Boshen
force-pushed
the
eslint-no-nonoctal-decimal-escape
branch
from
9e3e004
to
3ced575
Compare
Boshen
approved these changes
Feb 21, 2024
IWANABETHATGUY
pushed a commit
to IWANABETHATGUY/oxc
that referenced
this pull request
May 29, 2024
Rule [source](https://github.com/eslint/eslint/blob/main/lib/rules/no-nonoctal-decimal-escape.js) Rule [tests](https://github.com/eslint/eslint/blob/main/tests/lib/rules/no-nonoctal-decimal-escape.js) I created a basic sticky regex implementation based on what I could find about it, since rust does not have support for that. There might be a better place to keep it instead of this rule file --------- Co-authored-by: Boshen <boshenc@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rule source
Rule tests
I created a basic sticky regex implementation based on what I could find about it, since rust does not have support for that.
There might be a better place to keep it instead of this rule file