perf(parser): faster lexing template strings #2541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
CodSpeed Performance ReportMerging #2541 will not alter performanceComparing Summary
|
overlookmotel
force-pushed
the
02-28-perf_parser_faster_lexing_template_strings-v2
branch
from
a0c2576
to
8d9cd94
Compare
Base automatically changed from
02-28-refactor_parser_single_function_for_all_string_slicing
to
main
February 29, 2024 05:22
Boshen
force-pushed
the
02-28-perf_parser_faster_lexing_template_strings-v2
branch
from
8d9cd94
to
286a4a9
Compare
Boshen
deleted the
02-28-perf_parser_faster_lexing_template_strings-v2
branch
IWANABETHATGUY
pushed a commit
to IWANABETHATGUY/oxc
that referenced
this pull request
May 29, 2024
Speed up lexing template strings. This was the last use of `AutoCow` remaining in the lexer, and it's now removed. Implementation is quite complex, to avoid repeatedly branching on whether an unescaped string is required or not (the way `AutoCow` did). I tried to simplify it down to a single function, but this hurt performance significantly. Benchmarks do not show much movement, but I believe that's because there aren't many template strings in the benchmarks. Where there are template strings, I believe this speeds up lexing them significantly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speed up lexing template strings.
This was the last use of
AutoCowremaining in the lexer, and it's now removed.Implementation is quite complex, to avoid repeatedly branching on whether an unescaped string is required or not (the way
AutoCowdid). I tried to simplify it down to a single function, but this hurt performance significantly.Benchmarks do not show much movement, but I believe that's because there aren't many template strings in the benchmarks. Where there are template strings, I believe this speeds up lexing them significantly.