Fix getter return rule

[BlackSoulHub]

No description provided.

[Boshen]

I think the better choice is to not check for TypeScript, to align with typescript-eslint

https://github.com/typescript-eslint/typescript-eslint/blob/6954a4a463f9a2a1c20e41c91ee2c75c953dcc9f/packages/eslint-plugin/src/configs/eslint-recommended-raw.ts#L24

Created a new issue: #2544

[BlackSoulHub]

I think the better choice is to not check for TypeScript, to align with typescript-eslint

https://github.com/typescript-eslint/typescript-eslint/blob/6954a4a463f9a2a1c20e41c91ee2c75c953dcc9f/packages/eslint-plugin/src/configs/eslint-recommended-raw.ts#L24

Something like that?:

if ctx.source_type().is_typescript() {
    return (DefinitelyReturnsOrThrowsOrUnreachable::Yes, false);
}

[Boshen]

I think the better choice is to not check for TypeScript, to align with typescript-eslint
https://github.com/typescript-eslint/typescript-eslint/blob/6954a4a463f9a2a1c20e41c91ee2c75c953dcc9f/packages/eslint-plugin/src/configs/eslint-recommended-raw.ts#L24

Something like that?:

if ctx.source_type().is_typescript() {
    return (DefinitelyReturnsOrThrowsOrUnreachable::Yes, false);
}

I'll do the whole batch from the list.

And since you're comfortable with code, you may try https://eslint.org/docs/latest/rules/no-unreachable which is the last unimplemented cfg rule.

There's also constructor-super, getter-return and no-fallthrough that are all in nursery, which need some real world testing so we can bring them to the correctness category.

[Boshen]

Let's improve on this instead of skipping TypeScript files.

[codspeed-hq]

CodSpeed Performance Report

Merging #2543 will not alter performance

_{Comparing BlackSoulHub:main (8df4e9e) with main (dd31c64)}

Summary

✅ 27 untouched benchmarks

[BlackSoulHub]

I thought about what would happen to functions that return void? I check this later

[BlackSoulHub]

And since you're comfortable with code, you may try https://eslint.org/docs/latest/rules/no-unreachable which is the last unimplemented cfg rule.

I'll try to do it. But what about this PR?

[Boshen]

And since you're comfortable with code, you may try https://eslint.org/docs/latest/rules/no-unreachable which is the last unimplemented cfg rule.

I'll try to do it. But what about this PR?

I'll get this merged once all tests pass.