Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(linter): eslint-plugin-jest: prefer-to-have-length #2580

Merged
merged 6 commits into from
Mar 5, 2024
Merged

feat(linter): eslint-plugin-jest: prefer-to-have-length #2580

merged 6 commits into from
Mar 5, 2024

Conversation

eryue0220
Copy link
Contributor

Rule Detail: link

@github-actions github-actions bot added the A-linter Area - Linter label Mar 3, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 3, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #2580 will not alter performance

Comparing eryue0220:feat/jest-prefer-to-have-length (8d09b0b) with main (951297e)

Summary

✅ 29 untouched benchmarks

@Boshen Boshen requested a review from mysteryven March 3, 2024 06:00
@mysteryven
Copy link
Member

Need a rebase?

@eryue0220
Copy link
Contributor Author

Need a rebase?

Done.

mysteryven
mysteryven approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@mysteryven mysteryven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@mysteryven mysteryven merged commit 35ce3cc into oxc-project:main Mar 5, 2024
20 checks passed
@eryue0220 eryue0220 deleted the feat/jest-prefer-to-have-length branch March 5, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mysteryven mysteryven mysteryven approved these changes

Assignees
No one assigned
Labels
A-linter Area - Linter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eryue0220 @mysteryven