Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): support check ImportNamespaceSpecifier in no_import_assign #2617

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Mar 5, 2024

No description provided.

Copy link
Member Author

Dunqing commented Mar 5, 2024

Copy link

codspeed-hq bot commented Mar 5, 2024

CodSpeed Performance Report

Merging #2617 will not alter performance

Comparing 03-05-feat_linter_support_check_ImportNamespaceSpecifier_in_no_import_assign (bbd69db) with main (47e735a)

Summary

✅ 29 untouched benchmarks

@Dunqing Dunqing force-pushed the 03-05-feat_linter_support_check_ImportNamespaceSpecifier_in_no_import_assign branch 2 times, most recently from 7ac7f1d to 7831b21 Compare March 6, 2024 03:08
@Dunqing Dunqing marked this pull request as ready for review March 6, 2024 03:10
@Dunqing Dunqing force-pushed the 03-05-feat_linter_support_check_ImportNamespaceSpecifier_in_no_import_assign branch from 7831b21 to cdbe56b Compare March 6, 2024 03:12
Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dunqing Dunqing force-pushed the 03-05-refactor_linter_improve_the_implementation_of_no_shadow_restricted_names_based_on_symbols branch 2 times, most recently from 7ea1e2d to 223bb09 Compare March 7, 2024 02:34
@Dunqing Dunqing force-pushed the 03-05-feat_linter_support_check_ImportNamespaceSpecifier_in_no_import_assign branch from cdbe56b to a9de4a0 Compare March 7, 2024 02:35
@Dunqing
Copy link
Member Author

Dunqing commented Mar 7, 2024

@Dunqing Dunqing force-pushed the 03-05-refactor_linter_improve_the_implementation_of_no_shadow_restricted_names_based_on_symbols branch from 223bb09 to 679ac4c Compare March 7, 2024 02:41
@Dunqing Dunqing force-pushed the 03-05-feat_linter_support_check_ImportNamespaceSpecifier_in_no_import_assign branch from a9de4a0 to da01fbe Compare March 7, 2024 02:42
Copy link
Member

Boshen commented Mar 7, 2024

Merge activity

  • Mar 6, 9:51 PM EST: @Boshen started a stack merge that includes this pull request via Graphite.
  • Mar 6, 9:52 PM EST: Graphite rebased this pull request as part of a merge.
  • Mar 6, 9:56 PM EST: @Boshen merged this pull request with Graphite.

Base automatically changed from 03-05-refactor_linter_improve_the_implementation_of_no_shadow_restricted_names_based_on_symbols to main March 7, 2024 02:51
@Boshen Boshen force-pushed the 03-05-feat_linter_support_check_ImportNamespaceSpecifier_in_no_import_assign branch from da01fbe to bbd69db Compare March 7, 2024 02:51
@Boshen Boshen merged commit 9b56134 into main Mar 7, 2024
22 checks passed
@Boshen Boshen deleted the 03-05-feat_linter_support_check_ImportNamespaceSpecifier_in_no_import_assign branch March 7, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(linter): eslint/no-import-assign (partially done, in nursery category)
2 participants