Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): no_template_curly_in_string #2763

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

JoSeBu1
Copy link
Contributor

@JoSeBu1 JoSeBu1 commented Mar 18, 2024

Rule detail: https://eslint.org/docs/latest/rules/no-template-curly-in-string

At first I implemented it with regex, but I think you are trying to avoid it for performance reasons, so I did it by searching for the chars.

I had some problems showing the span in the case of 'Hello, ${{foo: "bar"}.foo}' I think it turned out more or less well, however, if you think it can be done in another way I am willing to do it .

@github-actions github-actions bot added the A-linter Area - Linter label Mar 18, 2024
Copy link

codspeed-hq bot commented Mar 18, 2024

CodSpeed Performance Report

Merging #2763 will not alter performance

Comparing JoSeBu1:feat/no_template_curly_in_string (94549d4) with main (b82a5dd)

Summary

✅ 29 untouched benchmarks

@mysteryven
Copy link
Member

mysteryven commented Mar 19, 2024

I had some problems showing the span in the case of 'Hello, ${{foo: "bar"}.foo}' I think it turned out more or less well

Test on VSCode repo, most cases are nice, I think we can merge it first.🤔

@Dunqing Dunqing merged commit ac813a6 into oxc-project:main Mar 19, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants