Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(transformer/es2015): add Spread transformer #2831

Closed
wants to merge 3 commits into from
Closed

feat(transformer/es2015): add Spread transformer #2831

wants to merge 3 commits into from

Conversation

rzvxa
Copy link
Contributor

@rzvxa rzvxa commented Mar 26, 2024 •
edited
Loading

@rzvxa Graphite App
Copy link
Contributor Author

rzvxa commented Mar 26, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rzvxa and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added A-ast Area - AST A-transformer Area - Transformer / Transpiler labels Mar 26, 2024
@rzvxa rzvxa changed the title feat(trans): initial wireframe of the transformer feat(transformer/es2015): add Spread transformer Mar 26, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 26, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #2831 will not alter performance

⚠️ No base runs were found

Falling back to comparing 03-27-feat_transformer_es2015_add_spread_transformer (d71ec13) with main (d671007)

Summary

✅ 34 untouched benchmarks

@github-actions github-actions bot added A-linter Area - Linter A-parser Area - Parser A-semantic Area - Semantic A-codegen Area - Code Generation labels Mar 27, 2024
@rzvxa rzvxa force-pushed the 03-27-feat_transformer_es2015_add_spread_transformer branch 2 times, most recently from 007d062 to d8eeb59 Compare March 27, 2024 13:20
@rzvxa rzvxa mentioned this pull request Mar 29, 2024
Closed
@rzvxa rzvxa closed this Mar 29, 2024
@rzvxa
Copy link
Contributor Author

rzvxa commented Mar 29, 2024

closed in favor of doing a rewrite for the transformers.

#2859

@Boshen
Copy link
Member

Boshen commented Mar 29, 2024

Implementation is still useful so we'll keep the branch.

@Boshen Boshen deleted the 03-27-feat_transformer_es2015_add_spread_transformer branch August 12, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overlookmotel overlookmotel Awaiting requested review from overlookmotel overlookmotel will be requested when the pull request is marked ready for review overlookmotel is a code owner

@Dunqing Dunqing Awaiting requested review from Dunqing Dunqing will be requested when the pull request is marked ready for review Dunqing is a code owner

Assignees
No one assigned
Labels
A-ast Area - AST A-codegen Area - Code Generation A-linter Area - Linter A-parser Area - Parser A-semantic Area - Semantic A-transformer Area - Transformer / Transpiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rzvxa @Boshen