Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement(semantic/cfg): better control flow for switch statements. #3547

Conversation

rzvxa
Copy link
Contributor

@rzvxa rzvxa commented Jun 5, 2024

There was an issue similar to the one in loops see #3451 to #3453

Copy link

graphite-app bot commented Jun 5, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

codspeed-hq bot commented Jun 5, 2024

CodSpeed Performance Report

Merging #3547 will not alter performance

Comparing 06-05-improvement_semantic_cfg_better_control_flow_for_switch_statements (defef05) with main (59666e0)

Summary

✅ 22 untouched benchmarks

@rzvxa rzvxa force-pushed the 06-03-improvement_semantic_cfg_rework_error_path branch from baa85e5 to 86be84b Compare June 5, 2024 19:14
@rzvxa rzvxa force-pushed the 06-05-improvement_semantic_cfg_better_control_flow_for_switch_statements branch from 93ce1a6 to b257dee Compare June 5, 2024 19:15
@rzvxa rzvxa force-pushed the 06-03-improvement_semantic_cfg_rework_error_path branch from 86be84b to 78d9b27 Compare June 5, 2024 19:34
@rzvxa rzvxa force-pushed the 06-05-improvement_semantic_cfg_better_control_flow_for_switch_statements branch from b257dee to a8dfe85 Compare June 5, 2024 19:36
@rzvxa rzvxa force-pushed the 06-03-improvement_semantic_cfg_rework_error_path branch from 78d9b27 to 20d3e34 Compare June 5, 2024 19:47
@rzvxa rzvxa force-pushed the 06-05-improvement_semantic_cfg_better_control_flow_for_switch_statements branch from ef8d76b to ca5115d Compare June 5, 2024 19:47
@rzvxa rzvxa force-pushed the 06-03-improvement_semantic_cfg_rework_error_path branch from 20d3e34 to 10fcc29 Compare June 6, 2024 06:04
@rzvxa rzvxa force-pushed the 06-05-improvement_semantic_cfg_better_control_flow_for_switch_statements branch from ca5115d to a724297 Compare June 6, 2024 06:05
@rzvxa rzvxa force-pushed the 06-03-improvement_semantic_cfg_rework_error_path branch from 10fcc29 to 2ed1bb7 Compare June 6, 2024 06:13
@rzvxa rzvxa force-pushed the 06-05-improvement_semantic_cfg_better_control_flow_for_switch_statements branch from a724297 to e879638 Compare June 6, 2024 06:13
@rzvxa rzvxa force-pushed the 06-03-improvement_semantic_cfg_rework_error_path branch from 2ed1bb7 to ce302b4 Compare June 6, 2024 06:16
@rzvxa rzvxa force-pushed the 06-05-improvement_semantic_cfg_better_control_flow_for_switch_statements branch from e879638 to 433ca71 Compare June 6, 2024 06:16
@rzvxa rzvxa force-pushed the 06-03-improvement_semantic_cfg_rework_error_path branch from ce302b4 to 462af6d Compare June 6, 2024 12:52
@rzvxa rzvxa force-pushed the 06-05-improvement_semantic_cfg_better_control_flow_for_switch_statements branch from 433ca71 to 20b3c05 Compare June 6, 2024 12:52
@rzvxa rzvxa marked this pull request as ready for review June 6, 2024 13:13
@rzvxa rzvxa marked this pull request as draft June 6, 2024 14:33
@rzvxa rzvxa force-pushed the 06-03-improvement_semantic_cfg_rework_error_path branch from 462af6d to 9a2dc57 Compare June 6, 2024 15:23
@rzvxa rzvxa force-pushed the 06-05-improvement_semantic_cfg_better_control_flow_for_switch_statements branch 5 times, most recently from 70d6394 to 4a2db11 Compare June 6, 2024 18:39
@rzvxa rzvxa marked this pull request as ready for review June 12, 2024 23:01
@rzvxa rzvxa force-pushed the 06-03-improvement_semantic_cfg_rework_error_path branch from 0b13125 to b6a762d Compare June 12, 2024 23:08
@rzvxa rzvxa force-pushed the 06-05-improvement_semantic_cfg_better_control_flow_for_switch_statements branch from 4a2db11 to 797c5de Compare June 12, 2024 23:08
Copy link

graphite-app bot commented Jun 13, 2024

Merge activity

@Boshen Boshen force-pushed the 06-03-improvement_semantic_cfg_rework_error_path branch from b6a762d to 29808c4 Compare June 13, 2024 07:30
Boshen pushed a commit that referenced this pull request Jun 13, 2024
@Boshen Boshen force-pushed the 06-05-improvement_semantic_cfg_better_control_flow_for_switch_statements branch from 797c5de to 8eb2ead Compare June 13, 2024 07:30
@Boshen Boshen force-pushed the 06-03-improvement_semantic_cfg_rework_error_path branch from 29808c4 to 9b30971 Compare June 13, 2024 07:36
@Boshen Boshen force-pushed the 06-05-improvement_semantic_cfg_better_control_flow_for_switch_statements branch from 8eb2ead to defef05 Compare June 13, 2024 07:37
Base automatically changed from 06-03-improvement_semantic_cfg_rework_error_path to main June 13, 2024 07:44
@graphite-app graphite-app bot merged commit defef05 into main Jun 13, 2024
22 checks passed
@graphite-app graphite-app bot deleted the 06-05-improvement_semantic_cfg_better_control_flow_for_switch_statements branch June 13, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-semantic Area - Semantic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant