Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): panic in jsdoc/require-param #3590

Merged
merged 1 commit into from
Jun 8, 2024

Conversation

DonIsaac
Copy link
Contributor

@DonIsaac DonIsaac commented Jun 8, 2024

No description provided.

@DonIsaac DonIsaac added C-bug Category - Bug A-linter Area - Linter labels Jun 8, 2024
@DonIsaac DonIsaac self-assigned this Jun 8, 2024
Copy link

graphite-app bot commented Jun 8, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@DonIsaac DonIsaac requested a review from leaysgur June 8, 2024 22:39
Copy link

codspeed-hq bot commented Jun 8, 2024

CodSpeed Performance Report

Merging #3590 will not alter performance

Comparing don/linter/fix/require_param_panic (c1eb2db) with main (3ae567d)

Summary

✅ 22 untouched benchmarks

@DonIsaac DonIsaac merged commit f0b689d into main Jun 8, 2024
23 checks passed
@DonIsaac DonIsaac deleted the don/linter/fix/require_param_panic branch June 8, 2024 22:44
@leaysgur
Copy link
Contributor

leaysgur commented Jun 8, 2024

Thanks!🙏

@github-actions github-actions bot mentioned this pull request Jun 14, 2024
Boshen added a commit that referenced this pull request Jun 14, 2024
## [0.4.4] - 2024-06-14

### Features

- 8f5655d linter: Add eslint/no-useless-constructor (#3594) (Don Isaac)
- 29c78db linter: Implement
@typescript-eslint/explicit-function-return-type (#3455) (kaykdm)
- 21d3425 linter: Typescript-eslint no-useless-empty-export (#3605)
(keita hino)
- 85c3b83 linter: Eslint-plugin-jest/max-nested-describes (#3585)
(cinchen)
- f6d9ca6 linter: Add `eslint/sort-imports` rule (#3568) (Wang Wenzhe)
- 046ff3f linter/eslint: Add `no_unreachable` rule. (#3238) (rzvxa)
- e32ce00 linter/jsdoc: Implement require-param-name rule (#3636) (Yuji
Sugiura)
- 110661c linter/jsdoc: Implement require-param-description (#3621)
(Yuji Sugiura)
- d6370f1 linter/jsdoc: Implement require-param-type rule (#3601) (Yuji
Sugiura)
- d9c5b33 semantic/cfg: Add `Condition` instruction. (#3567) (Ali
Rezvani)
- f2dfd66 semantic/cfg: Add iteration instructions. (#3566) (rzvxa)

### Bug Fixes

- f0b689d linter: Panic in jsdoc/require-param (#3590) (Don Isaac)
- e148a32 semantic/cfg: Correct unreachability propagation in
try-finally. (#3667) (Ali Rezvani)

### Refactor

- 84304b4 linter: Add a `ctx.module_record()` method (#3637) (Boshen)
- f98f777 linter: Add rule fixer (#3589) (Don Isaac)
- fa11644 linter: Pass `Rc` by value (#3587) (overlookmotel)
- f702fb9 semantic/cfg: Cleanup control flow and it's builder. (#3650)
(rzvxa)
- 5793ff1 transformer: Replace `&’a Trivias` with `Rc<Trivias>` (#3580)
(Dunqing)

Co-authored-by: Boshen <Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants