Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve(transformer): avoid reallocating strings #3817

Merged

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Jun 21, 2024

Re-use existing Atoms rather than allocating duplicate strings in TS transforms.

Copy link

graphite-app bot commented Jun 21, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

overlookmotel commented Jun 21, 2024

@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Jun 21, 2024
@overlookmotel overlookmotel marked this pull request as ready for review June 21, 2024 23:43
Copy link

codspeed-hq bot commented Jun 21, 2024

CodSpeed Performance Report

Merging #3817 will not alter performance

Comparing 06-22-improve_transformer_avoid_reallocating_strings (aaa944d) with main (2cdb34f)

Summary

✅ 28 untouched benchmarks

Copy link

graphite-app bot commented Jun 22, 2024

Merge activity

Re-use existing `Atom`s rather than allocating duplicate strings in TS transforms.
@Boshen Boshen force-pushed the 06-22-fix_transformer_fix_ts_annotation_transform_scopes branch from 43be281 to 6dcc3f4 Compare June 22, 2024 04:48
@Boshen Boshen force-pushed the 06-22-improve_transformer_avoid_reallocating_strings branch from d6b498d to aaa944d Compare June 22, 2024 04:48
@Boshen Boshen changed the base branch from 06-22-fix_transformer_fix_ts_annotation_transform_scopes to main June 22, 2024 04:51
@graphite-app graphite-app bot merged commit aaa944d into main Jun 22, 2024
24 checks passed
@graphite-app graphite-app bot deleted the 06-22-improve_transformer_avoid_reallocating_strings branch June 22, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-transformer Area - Transformer / Transpiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant