Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(napi/transform): add crate-type: "lib" #3876

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

underfin
Copy link
Contributor

@underfin underfin commented Jun 24, 2024

The pr add a crate-type: lib for transform binding, it will be used for rolldown export binding. I tested the binary size 895k -> 944K, it could be acceptable.

Here bump the napi library version due to rolldown napi version is used 3.0.0-alpha, different napi version make rolldown release build error.

It means the binding library need to publish to crate.io, @Boshen Could you add it to ci pipeline for it? I'm not familiar for it.

Copy link

graphite-app bot commented Jun 24, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@Boshen
Copy link
Member

Boshen commented Jun 24, 2024

This doesn't contain oxc_transformr yet, please create an issue if you want one 😅

@underfin
Copy link
Contributor Author

Yeah. I konw i will work on it at next.

Copy link

codspeed-hq bot commented Jun 24, 2024

CodSpeed Performance Report

Merging #3876 will not alter performance

Comparing underfin:transform-binding-library (a74e0d4) with main (8c61f9c)

Summary

✅ 28 untouched benchmarks

@Boshen
Copy link
Member

Boshen commented Jun 24, 2024

It means the binding library need to publish to crate.io

Ok, I'll take a look, feels pretty weird though 🤔

@underfin
Copy link
Contributor Author

The rolldown related pr at rolldown/rolldown#1434, maybe you need to use it.

@Boshen Boshen changed the title feat: make transform binding could be a library feat(napi/transform): add crate-type: "lib" Jun 26, 2024
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jun 26, 2024
Copy link

graphite-app bot commented Jun 26, 2024

Merge activity

  • Jun 26, 9:55 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jun 26, 9:55 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • Jun 26, 9:56 AM EDT: The Graphite merge queue wasn't able to merge this pull request due to Stack merges are not currently supported for forked repositories. Please create a branch in the target repository in order to merge.
  • Jun 26, 9:56 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jun 26, 9:56 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • Jun 26, 9:57 AM EDT: The Graphite merge queue wasn't able to merge this pull request due to Stack merges are not currently supported for forked repositories. Please create a branch in the target repository in order to merge.

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jun 26, 2024
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jun 26, 2024 — with Graphite App
@Boshen Boshen merged commit bbe8336 into oxc-project:main Jun 26, 2024
25 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants