-
-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(napi/transform): add crate-type: "lib"
#3876
Conversation
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This doesn't contain oxc_transformr yet, please create an issue if you want one 😅 |
Yeah. I konw i will work on it at next. |
CodSpeed Performance ReportMerging #3876 will not alter performanceComparing Summary
|
Ok, I'll take a look, feels pretty weird though 🤔 |
The rolldown related pr at rolldown/rolldown#1434, maybe you need to use it. |
crate-type: "lib"
Merge activity
|
The pr add a
crate-type: lib
for transform binding, it will be used for rolldown export binding. I tested the binary size 895k -> 944K, it could be acceptable.Here bump the napi library version due to rolldown napi version is used
3.0.0-alpha
, different napi version make rolldown release build error.It means the binding library need to publish to crate.io, @Boshen Could you add it to ci pipeline for it? I'm not familiar for it.