feat(ast): allow conversion from Expression into Statement with FromIn trait.
#4124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This was referenced Jul 8, 2024
CodSpeed Performance ReportMerging #4124 will not alter performanceComparing Summary
|
rzvxa
changed the title
ExpressionStatement and Statement with FromIn trait.Expression into Statement with FromIn trait.
rzvxa
force-pushed
the
07-08-refactor_ast_ast_builder_shorter_allocator_utility_method_names
branch
from
1a82128 to
451cf2e
Compare
rzvxa
force-pushed
the
07-08-feat_ast_allow_conversion_between_expressionstatement_and_statement_with_fromin_trait
branch
from
bf33017 to
05f1f4d
Compare
overlookmotel
approved these changes
Jul 9, 2024
rzvxa
force-pushed
the
07-08-feat_ast_allow_conversion_between_expressionstatement_and_statement_with_fromin_trait
branch
2 times, most recently
from
0634b50 to
d91c6a1
Compare
overlookmotel
force-pushed
the
07-08-refactor_ast_ast_builder_shorter_allocator_utility_method_names
branch
from
05e145b to
e69c323
Compare
overlookmotel
force-pushed
the
07-08-feat_ast_allow_conversion_between_expressionstatement_and_statement_with_fromin_trait
branch
from
d91c6a1 to
aec2e90
Compare
overlookmotel
force-pushed
the
07-08-refactor_ast_ast_builder_shorter_allocator_utility_method_names
branch
from
e69c323 to
2943085
Compare
overlookmotel
force-pushed
the
07-08-feat_ast_allow_conversion_between_expressionstatement_and_statement_with_fromin_trait
branch
from
aec2e90 to
195c762
Compare
Merge activity
|
Boshen
force-pushed
the
07-08-refactor_ast_ast_builder_shorter_allocator_utility_method_names
branch
from
2943085 to
69cea86
Compare
Boshen
pushed a commit
that referenced
this pull request
Jul 9, 2024
…FromIn` trait. (#4124) Our downstream rolldown is using this, If we want them to adopt our traits we should provide this implementation for them. https://github.com/rolldown/rolldown/blob/2cd2a367ee25c3d1f711fda9b1d3ead5982cfcff/crates/rolldown_ecmascript/src/allocator_helpers/into_in.rs#L24
Boshen
force-pushed
the
07-08-feat_ast_allow_conversion_between_expressionstatement_and_statement_with_fromin_trait
branch
from
195c762 to
3536aaf
Compare
rzvxa
force-pushed
the
07-08-refactor_ast_ast_builder_shorter_allocator_utility_method_names
branch
from
69cea86 to
c5a6e9e
Compare
rzvxa
added a commit
that referenced
this pull request
Jul 9, 2024
…FromIn` trait. (#4124) Our downstream rolldown is using this, If we want them to adopt our traits we should provide this implementation for them. https://github.com/rolldown/rolldown/blob/2cd2a367ee25c3d1f711fda9b1d3ead5982cfcff/crates/rolldown_ecmascript/src/allocator_helpers/into_in.rs#L24
rzvxa
force-pushed
the
07-08-feat_ast_allow_conversion_between_expressionstatement_and_statement_with_fromin_trait
branch
from
3536aaf to
a859564
Compare
…FromIn` trait. (#4124) Our downstream rolldown is using this, If we want them to adopt our traits we should provide this implementation for them. https://github.com/rolldown/rolldown/blob/2cd2a367ee25c3d1f711fda9b1d3ead5982cfcff/crates/rolldown_ecmascript/src/allocator_helpers/into_in.rs#L24
rzvxa
force-pushed
the
07-08-refactor_ast_ast_builder_shorter_allocator_utility_method_names
branch
from
c5a6e9e to
b936162
Compare
rzvxa
force-pushed
the
07-08-feat_ast_allow_conversion_between_expressionstatement_and_statement_with_fromin_trait
branch
from
a859564 to
485c871
Compare
rzvxa
changed the base branch from
07-08-refactor_ast_ast_builder_shorter_allocator_utility_method_names
to
main
graphite-app
bot
deleted the
07-08-feat_ast_allow_conversion_between_expressionstatement_and_statement_with_fromin_trait
branch
Merged
Boshen
added a commit
that referenced
this pull request
Jul 9, 2024
## [0.19.0] - 2024-07-09 - b936162 ast/ast_builder: [**BREAKING**] Shorter allocator utility method names. (#4122) (rzvxa) ### Features - 485c871 ast: Allow conversion from `Expression` into `Statement` with `FromIn` trait. (#4124) (rzvxa) ### Refactor Co-authored-by: Boshen <Boshen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our downstream rolldown is using this, If we want them to adopt our traits we should provide this implementation for them.
https://github.com/rolldown/rolldown/blob/2cd2a367ee25c3d1f711fda9b1d3ead5982cfcff/crates/rolldown_ecmascript/src/allocator_helpers/into_in.rs#L24