Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(linter): fix top level return panic in eslint/array_callback_return #4167

Merged
merged 1 commit into from
Jul 10, 2024
Merged

fix(linter): fix top level return panic in eslint/array_callback_return #4167

merged 1 commit into from
Jul 10, 2024

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Jul 10, 2024

No description provided.

@Boshen Graphite App
Copy link
Member Author

Boshen commented Jul 10, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Boshen and the rest of your teammates on Graphite Graphite

This was referenced Jul 10, 2024
Merged
Merged
Merged
@github-actions github-actions bot added the A-linter Area - Linter label Jul 10, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Jul 10, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jul 10, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Jul 10, 2024 •
edited
Loading

Merge activity

  • Jul 10, 10:39 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jul 10, 10:39 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • Jul 10, 10:40 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jul 10, 10:58 AM EDT: The Graphite merge queue removed this pull request due to downstack failures on PR #4166.
  • Jul 10, 10:58 AM EDT: The Graphite merge queue removed this pull request due to downstack failures on PR #4166.
  • Jul 10, 10:59 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jul 10, 11:26 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • Jul 10, 11:32 AM EDT: Boshen merged this pull request with the Graphite merge queue.
  • Jul 10, 11:42 AM EDT: Boshen added this pull request to the Graphite merge queue.

@Boshen Boshen force-pushed the 07-10-fix_linter_fix_panic_in_unicorn_prefer_dom_node_dataset branch from d09c737 to a33e0e1 Compare July 10, 2024 14:42
Boshen added a commit that referenced this pull request Jul 10, 2024
@Boshen
fix(linter): fix top level return panic in eslint/array_callback_retu…
e517813 
…rn (#4167)
@Boshen Boshen force-pushed the 07-10-fix_linter_fix_top_level_return_panic_in_eslint_array_callback_return branch from ecd534d to e517813 Compare July 10, 2024 14:42
@Boshen Boshen force-pushed the 07-10-fix_linter_fix_panic_in_unicorn_prefer_dom_node_dataset branch from a33e0e1 to 7967237 Compare July 10, 2024 14:46
Boshen added a commit that referenced this pull request Jul 10, 2024
@Boshen
fix(linter): fix top level return panic in eslint/array_callback_retu…
f3f06a5 
…rn (#4167)
@Boshen Boshen force-pushed the 07-10-fix_linter_fix_top_level_return_panic_in_eslint_array_callback_return branch from e517813 to f3f06a5 Compare July 10, 2024 14:47
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 10, 2024
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jul 10, 2024 — with Graphite App
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 10, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #4167 will not alter performance

Comparing 07-10-fix_linter_fix_top_level_return_panic_in_eslint_array_callback_return (a64848b) with main (c8f5664)

Summary

✅ 29 untouched benchmarks

@Boshen Boshen force-pushed the 07-10-fix_linter_fix_panic_in_unicorn_prefer_dom_node_dataset branch from 33c74a3 to c8f5664 Compare July 10, 2024 15:14
@Boshen Boshen changed the base branch from 07-10-fix_linter_fix_panic_in_unicorn_prefer_dom_node_dataset to main July 10, 2024 15:18
Boshen added a commit that referenced this pull request Jul 10, 2024
@Boshen
fix(linter): fix top level return panic in eslint/array_callback_retu…
a64848b 
…rn (#4167)
@Boshen Boshen force-pushed the 07-10-fix_linter_fix_top_level_return_panic_in_eslint_array_callback_return branch from f3f06a5 to a64848b Compare July 10, 2024 15:18
@Boshen Boshen force-pushed the 07-10-fix_linter_fix_top_level_return_panic_in_eslint_array_callback_return branch from a64848b to bd69571 Compare July 10, 2024 15:28
@graphite-app graphite-app bot merged commit bd69571 into main Jul 10, 2024
26 checks passed
@graphite-app graphite-app bot deleted the 07-10-fix_linter_fix_top_level_return_panic_in_eslint_array_callback_return branch July 10, 2024 15:32
@github-actions github-actions bot mentioned this pull request Jul 11, 2024
Merged
Boshen added a commit that referenced this pull request Jul 11, 2024
@github-actions @Boshen
Release oxlint v0.6.0 (#4194)
4f26e51 
## [0.6.0] - 2024-07-11

- 5731e39 ast: [**BREAKING**] Store span details inside comment struct
(#4132) (Luca Bruno)

### Features

- fb549e1 linter: Add vitest/no-focused-tests rule (#4178) (mysteryven)
- 6c49007 linter: Add fixer for
@typescript-eslint/consistent-type-imports (#3984) (mysteryven)
- 278c3e9 linter: Add fixer for jsx-a11y/aria-props (#4176) (DonIsaac)
- 2188144 linter: Eslint-plugin-jest/prefer-hooks-in-order (#4052)
(cinchen)
- cc58614 linter: Better schemas for allow/warn/deny (#4150) (DonIsaac)
- c5b4be0 linter: Add fixer for prefer-node-protocol (#4129) (DonIsaac)
- 7ec0c0b linter/eslint: Implement no-label-var (#4087) (Jelle van der
Waa)

### Bug Fixes

- ed4c54c eslint/radix: Detect yield Number.parseInt variant (#4110)
(Jelle van der Waa)
- e9ad03b linter: Fixer for no-debugger creates incorrect code (#4184)
(DonIsaac)
- bd69571 linter: Fix top level return panic in
eslint/array_callback_return (#4167) (Boshen)
- c8f5664 linter: Fix panic with unicode in
unicorn/prefer_dom_node_dataset (#4166) (Boshen)
- f2b3273 linter: Fix fixer panic in
typescript/consistent_indexed_object_style (#4165) (Boshen)
- 2334515 linter: Panic in `get_enclosing_function` (#4121) (DonIsaac)
- 1b91d40 linter: Incorrect fixer for `no-unused-labels` (#4123) (Don
Isaac)
- 1729249 linter: Incorrect fix in
`no-single-promise-in-promise-methods` rule; (#4094) (DonIsaac)
- cc7e893 linter/tree-shaking: Avoid recursive function stackoverflow
(#4191) (mysteryven)
- 28eeee0 parser: Fix asi error diagnostic pointing at invalid text
causing crash (#4163) (Boshen)
- 0f02608 semantic: Bind `TSImportEqualsDeclaration`s (#4100) (Don
Isaac)

### Performance

- ddfa343 diagnostic: Use `Cow<'static, str>` over `String` (#4175)
(DonIsaac)

### Refactor

- 2687ebc react: Use find_binding helper for finding React binding
(#4108) (Jelle van der Waa)

Co-authored-by: Boshen <Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0-merge Merge with Graphite Merge Queue A-linter Area - Linter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Boshen