perf(semantic): reduce cloning CompactStrs when declaring references

[overlookmotel]

The hash map Entry API requires an owned key. Avoid using it so don't have to clone the reference name CompactStr unless the hashmap need an insertion.

Using Atom instead of CompactStr as hash map key (#3972) would be a better long-term solution, but that's not possible currently.

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[overlookmotel]

• perf(semantic): reduce cloning CompactStrs when declaring references #4239 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite

[codspeed-hq]

CodSpeed Performance Report

Merging #4239 will degrade performances by 3.2%

_{Comparing 07-12-perf_semantic_reduce_cloning_compactstr_s_when_declaring_references (b8f36f0) with main (c65198f)}

Summary

❌ 1 regressions
✅ 31 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	main	07-12-perf_semantic_reduce_cloning_compactstr_s_when_declaring_references	Change
❌	semantic[checker.ts]	117.1 ms	121 ms	-3.2%

[overlookmotel]

Od dear. That didn't work.