Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(linter): only computed regex once in jsx-a11y/no-redundant-alt #4515

Conversation

camc314
Copy link
Collaborator

@camc314 camc314 commented Jul 28, 2024

No description provided.

Copy link

graphite-app bot commented Jul 28, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

camc314 commented Jul 28, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @camc314 and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the A-linter Area - Linter label Jul 28, 2024
Copy link

codspeed-hq bot commented Jul 28, 2024

CodSpeed Performance Report

Merging #4515 will not alter performance

Comparing c/07-28-perf_linter_jsx-a11y_img_redundant_aly_only_compute_regex_once (6cde9b5) with main (7446e98)

Summary

✅ 32 untouched benchmarks

@camc314
Copy link
Collaborator Author

camc314 commented Jul 28, 2024

not sure whether this is worth merging, look like a 3% perf improvement on the cal.com benchmark. but no other real changes.

will leave up to you guys - feel free to close

@camc314 camc314 marked this pull request as ready for review July 28, 2024 17:19
Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DonIsaac DonIsaac added the C-performance Category - Solution not expected to change functional behavior, only performance label Jul 29, 2024
@overlookmotel
Copy link
Collaborator

overlookmotel commented Jul 29, 2024

You can use the latest https://doc.rust-lang.org/std/sync/struct.LazyLock.html now.

Are we OK only supporting >= Rust 1.80.0?

3% perf improvement on the cal.com benchmark. but no other real changes.

3% is definitely worth it!

@DonIsaac DonIsaac changed the title perf(linter) jsx-a11y img redundant aly only compute regex once perf(linter): jsx-a11y/img-redundant aly only compute regex once Jul 29, 2024
@DonIsaac DonIsaac changed the title perf(linter): jsx-a11y/img-redundant aly only compute regex once perf(linter): only computed regex once in jsx-a11y/no-redundant-alt Jul 29, 2024
@Dunqing
Copy link
Member

Dunqing commented Jul 30, 2024

You can use the latest https://doc.rust-lang.org/std/sync/struct.LazyLock.html now.

Are we OK only supporting >= Rust 1.80.0?

I think yes, we don't publish oxlint-relates crates, so oxlint without limitation of MSRV

@DonIsaac
Copy link
Collaborator

DonIsaac commented Aug 4, 2024

Replaced by #4604

@DonIsaac DonIsaac closed this Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants