-
-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(linter): only computed regex once in jsx-a11y/no-redundant-alt #4515
perf(linter): only computed regex once in jsx-a11y/no-redundant-alt #4515
Conversation
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #4515 will not alter performanceComparing Summary
|
not sure whether this is worth merging, look like a 3% perf improvement on the cal.com benchmark. but no other real changes. will leave up to you guys - feel free to close |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use the latest https://doc.rust-lang.org/std/sync/struct.LazyLock.html now.
Are we OK only supporting >= Rust 1.80.0?
3% is definitely worth it! |
I think yes, we don't publish oxlint-relates crates, so oxlint without limitation of MSRV |
Replaced by #4604 |
No description provided.