-
-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ast_codegen): move away from RType
in generators.
#4682
refactor(ast_codegen): move away from RType
in generators.
#4682
Conversation
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
CodSpeed Performance ReportMerging #4682 will not alter performanceComparing Summary
|
009c234
to
b51e7b0
Compare
b691815
to
1350541
Compare
1d1315e
to
a2621cd
Compare
1350541
to
05d5cd6
Compare
a2621cd
to
e24fb5b
Compare
Merge activity
|
This PR introduces `EarlyCtx` and `LateCtx` in place of the old `CodegenCtx`, Early passes operate at the AST level while generators and other late passes operate on the schema. It will also replace the confusing `RType` name with something more idiomatic ~~(open for suggestions, I haven't found a good name yet)~~ I've named it `AstType` and dropped the `R` prefix for `REnum` and `RStruct`. There are some qualities of life improvements too, Things like `to_type_elide` can be used to simplify the code. Related to #4442 (and can potentially mark it "close as fixed").
05d5cd6
to
1690a57
Compare
This PR introduces
EarlyCtx
andLateCtx
in place of the oldCodegenCtx
, Early passes operate at the AST level while generators and other late passes operate on the schema.It will also replace the confusing
RType
name with something more idiomatic(open for suggestions, I haven't found a good name yet)I've named itAstType
and dropped theR
prefix forREnum
andRStruct
.There are some qualities of life improvements too, Things like
to_type_elide
can be used to simplify the code.Related to #4442 (and can potentially mark it "close as fixed").