Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ast_codegen): move formatting regex definitions #4775

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Aug 9, 2024

Pure refactor. Move the regex definitions used in formatting to next to the Replacers for those regexes.

Copy link

graphite-app bot commented Aug 9, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

codspeed-hq bot commented Aug 9, 2024

CodSpeed Performance Report

Merging #4775 will not alter performance

Comparing 08-09-refactor_ast_codegen_move_formatting_regex_definitions (c15c931) with main (daa0b2e)

Summary

✅ 29 untouched benchmarks

@overlookmotel overlookmotel force-pushed the 08-09-refactor_ast_codegen_move_formatting_regex_definitions branch from b2c289c to 891075b Compare August 9, 2024 05:42
@overlookmotel overlookmotel force-pushed the 08-09-refactor_ast_codegen_remove_unnecessary_imports_from_generated_files branch from d787af5 to fb10b6d Compare August 9, 2024 06:25
@overlookmotel overlookmotel force-pushed the 08-09-refactor_ast_codegen_move_formatting_regex_definitions branch from 891075b to 1266d4d Compare August 9, 2024 06:25
tasks/ast_codegen/src/fmt.rs Outdated Show resolved Hide resolved
@rzvxa rzvxa force-pushed the 08-09-refactor_ast_codegen_remove_unnecessary_imports_from_generated_files branch from fb10b6d to 87ed56b Compare August 9, 2024 07:17
@rzvxa rzvxa force-pushed the 08-09-refactor_ast_codegen_move_formatting_regex_definitions branch from 1266d4d to 09d8aec Compare August 9, 2024 07:18
@overlookmotel overlookmotel force-pushed the 08-09-refactor_ast_codegen_move_formatting_regex_definitions branch from 09d8aec to 3136858 Compare August 9, 2024 07:32
@overlookmotel overlookmotel force-pushed the 08-09-refactor_ast_codegen_move_formatting_regex_definitions branch from 3136858 to 0b9a2eb Compare August 9, 2024 07:39
@overlookmotel overlookmotel requested a review from rzvxa August 9, 2024 07:41
@rzvxa rzvxa added the 0-merge Merge with Graphite Merge Queue label Aug 9, 2024
Copy link

graphite-app bot commented Aug 9, 2024

Merge activity

  • Aug 9, 3:47 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 9, 3:47 AM EDT: rzvxa added this pull request to the Graphite merge queue.
  • Aug 9, 3:54 AM EDT: rzvxa merged this pull request with the Graphite merge queue.

Pure refactor. Move the regex definitions used in formatting to next to the `Replacer`s for those regexes.
@rzvxa rzvxa force-pushed the 08-09-refactor_ast_codegen_remove_unnecessary_imports_from_generated_files branch from 87ed56b to dbb5f4c Compare August 9, 2024 07:48
@rzvxa rzvxa force-pushed the 08-09-refactor_ast_codegen_move_formatting_regex_definitions branch from 0b9a2eb to c15c931 Compare August 9, 2024 07:49
Base automatically changed from 08-09-refactor_ast_codegen_remove_unnecessary_imports_from_generated_files to main August 9, 2024 07:52
@graphite-app graphite-app bot merged commit c15c931 into main Aug 9, 2024
24 checks passed
@graphite-app graphite-app bot deleted the 08-09-refactor_ast_codegen_move_formatting_regex_definitions branch August 9, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants