Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(website): rename fields in Playground from flag to flags #5033

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Aug 20, 2024

Part of #4991.

@overlookmotel
Copy link
Contributor Author

@DonIsaac I'm not familiar with playground, and I'm not sure if it's tested in CI. Does this look like it'd cause any problems?

@overlookmotel
Copy link
Contributor Author

PS: This concludes my one-man war on "flag"!

@DonIsaac
Copy link
Contributor

@DonIsaac I'm not familiar with playground, and I'm not sure if it's tested in CI. Does this look like it'd cause any problems?

It's possible; I can test it out locally.

Copy link

graphite-app bot commented Aug 20, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@DonIsaac
Copy link
Contributor

Approved, but please don't merge this yet

@overlookmotel
Copy link
Contributor Author

overlookmotel commented Aug 20, 2024

Approved, but please don't merge this yet

OK cool. I'm off to bed. I'm not sure of the reason for saying "don't merge this yet". If whatever question/problem is the blocker is resolved/becomes clear, if you have the energy/bandwidth, and you think the stack as a whole is OK, please can you merge it? But if any problems or queries outstanding, no worries - just let me know and I'll pick it up tomorrow.

Or just leave it and enjoy your evening!

@DonIsaac
Copy link
Contributor

LGTM
image

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Aug 21, 2024
Copy link

graphite-app bot commented Aug 21, 2024

Merge activity

  • Aug 20, 8:15 PM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 20, 8:15 PM EDT: Boshen added this pull request to the Graphite merge queue.
  • Aug 20, 8:46 PM EDT: Boshen merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the 08-20-refactor_semantic_rename_fields_in_snapshots_from_flag_to_flags_ branch from adf2f07 to 4336a32 Compare August 21, 2024 00:24
@Boshen Boshen force-pushed the 08-20-refactor_website_rename_fields_in_playground_from_flag_to_flags_ branch from 2728957 to 79c2493 Compare August 21, 2024 00:25
Base automatically changed from 08-20-refactor_semantic_rename_fields_in_snapshots_from_flag_to_flags_ to main August 21, 2024 00:44
@graphite-app graphite-app bot merged commit 79c2493 into main Aug 21, 2024
16 checks passed
@graphite-app graphite-app bot deleted the 08-20-refactor_website_rename_fields_in_playground_from_flag_to_flags_ branch August 21, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants