-
-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(website): rename fields in Playground from flag
to flags
#5033
refactor(website): rename fields in Playground from flag
to flags
#5033
Conversation
@DonIsaac I'm not familiar with playground, and I'm not sure if it's tested in CI. Does this look like it'd cause any problems? |
PS: This concludes my one-man war on "flag"! |
It's possible; I can test it out locally. |
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Approved, but please don't merge this yet |
OK cool. I'm off to bed. I'm not sure of the reason for saying "don't merge this yet". If whatever question/problem is the blocker is resolved/becomes clear, if you have the energy/bandwidth, and you think the stack as a whole is OK, please can you merge it? But if any problems or queries outstanding, no worries - just let me know and I'll pick it up tomorrow. Or just leave it and enjoy your evening! |
Merge activity
|
adf2f07
to
4336a32
Compare
2728957
to
79c2493
Compare
Part of #4991.