chore(regular_expression): Update example to support RegExp constructor #5106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #5106 will not alter performanceComparing Summary
|
Merge activity
|
…or (#5106) - Fix example to handle `new RegExp()` too - Update NOTE comments - - - Until I tried interacting with the actual AST parsed by `oxc_parser`, I thought that the current `oxc_regular_expression` lacked support for the `RegExp` constructor due to escape sequences. This was because `"\""` remained `"\""` after reading the source text from `.js` files. However, once it was parsed by `oxc_parser`, I found that everything was [resolved](https://github.com/oxc-project/oxc/blob/8ef85a43c019a1ce9aa50b61ec4dbb5dbaeb3b7b/crates/oxc_parser/src/lexer/string.rs)! (Wonderful work as usual. 👏🏻 ) Now there is nothing to worry about. 😌
82 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new RegExp()tooUntil I tried interacting with the actual AST parsed by
oxc_parser, I thought that the currentoxc_regular_expressionlacked support for theRegExpconstructor due to escape sequences.This was because
"\""remained"\""after reading the source text from.jsfiles.However, once it was parsed by
oxc_parser, I found that everything was resolved! (Wonderful work as usual. 👏🏻 )Now there is nothing to worry about. 😌