refactor(ast_tools): remove support for #[scope(if(...))] attr
#5113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This was referenced Aug 23, 2024
CodSpeed Performance ReportMerging #5113 will not alter performanceComparing Summary
|
Merge activity
|
There are no longer any nodes with conditional scopes. Remove support for `#[scope(if(...))]` attr from `ast_tools` - it's no longer needed.
Dunqing
force-pushed
the
08-23-refactor_traverse_refactor_childscopecollector_
branch
from
8830b4b to
1ba11a3
Compare
Dunqing
force-pushed
the
08-23-refactor_ast_tools_remove_support_for_scope_if_._attr
branch
from
4ab7522 to
8650d3e
Compare
Base automatically changed from
08-23-refactor_traverse_refactor_childscopecollector_
to
main
August 23, 2024 09:35
graphite-app
bot
deleted the
08-23-refactor_ast_tools_remove_support_for_scope_if_._attr
branch
This was referenced Aug 23, 2024
Dunqing
pushed a commit
that referenced
this pull request
Aug 23, 2024
There are no longer any nodes with conditional scopes. Remove support for `#[scope(if(...))]` attr from `ast_tools` - it's no longer needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are no longer any nodes with conditional scopes. Remove support for
#[scope(if(...))]attr fromast_tools- it's no longer needed.