Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(linter): start internal/external split of LintPluginOptions #5142

Conversation

DonIsaac
Copy link
Contributor

No description provided.

@DonIsaac DonIsaac marked this pull request as ready for review August 23, 2024 18:43
@github-actions github-actions bot added the A-linter Area - Linter label Aug 23, 2024
@DonIsaac DonIsaac force-pushed the don/08-23-refactor_linter_start_internal/external_split_of_oxlintoptions branch from 6844217 to 3324d87 Compare August 23, 2024 18:57
@DonIsaac DonIsaac force-pushed the don/08-23-refactor_linter_start_internal/external_split_of_lintpluginoptions branch from 56ef2dc to 808c49c Compare August 23, 2024 18:57
@DonIsaac DonIsaac force-pushed the don/08-23-refactor_linter_start_internal/external_split_of_oxlintoptions branch from 3324d87 to 3bacf40 Compare August 23, 2024 19:05
@github-actions github-actions bot added the A-cli Area - CLI label Aug 23, 2024
@DonIsaac DonIsaac force-pushed the don/08-23-refactor_linter_start_internal/external_split_of_lintpluginoptions branch from 808c49c to c21d2d5 Compare August 23, 2024 19:06
Copy link

codspeed-hq bot commented Aug 23, 2024

CodSpeed Performance Report

Merging #5142 will improve performances by 8.1%

Comparing don/08-23-refactor_linter_start_internal/external_split_of_lintpluginoptions (d28af6c) with don/08-23-refactor_linter_start_internal/external_split_of_oxlintoptions (1df5986)

Summary

⚡ 1 improvements
✅ 28 untouched benchmarks

Benchmarks breakdown

Benchmark don/08-23-refactor_linter_start_internal/external_split_of_oxlintoptions don/08-23-refactor_linter_start_internal/external_split_of_lintpluginoptions Change
transformer[cal.com.tsx] 12.1 ms 11.2 ms +8.1%

@DonIsaac DonIsaac force-pushed the don/08-23-refactor_linter_start_internal/external_split_of_oxlintoptions branch from 3bacf40 to 46583ad Compare August 23, 2024 19:37
@DonIsaac DonIsaac force-pushed the don/08-23-refactor_linter_start_internal/external_split_of_lintpluginoptions branch from c21d2d5 to 6a496f9 Compare August 23, 2024 19:37
@DonIsaac DonIsaac added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Aug 23, 2024
@DonIsaac DonIsaac marked this pull request as draft August 24, 2024 04:45
@DonIsaac DonIsaac force-pushed the don/08-23-refactor_linter_start_internal/external_split_of_oxlintoptions branch from 46583ad to a222582 Compare August 29, 2024 16:02
@DonIsaac DonIsaac force-pushed the don/08-23-refactor_linter_start_internal/external_split_of_lintpluginoptions branch from 6a496f9 to 2573439 Compare August 29, 2024 16:02
@DonIsaac DonIsaac force-pushed the don/08-23-refactor_linter_start_internal/external_split_of_oxlintoptions branch from a222582 to 1df5986 Compare August 29, 2024 21:13
@DonIsaac DonIsaac force-pushed the don/08-23-refactor_linter_start_internal/external_split_of_lintpluginoptions branch from 2573439 to d28af6c Compare August 29, 2024 21:13
@DonIsaac DonIsaac closed this Oct 7, 2024
@Boshen Boshen deleted the don/08-23-refactor_linter_start_internal/external_split_of_lintpluginoptions branch December 13, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Area - CLI A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant