Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wasm): output symbol IDs in scope tree #5266

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Aug 27, 2024

oxc_wasm include SymbolIds in print-out of scopes.

Copy link
Contributor Author

overlookmotel commented Aug 27, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite Graphite

Copy link

graphite-app bot commented Aug 27, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@overlookmotel overlookmotel marked this pull request as ready for review August 27, 2024 13:22
@overlookmotel overlookmotel requested a review from Boshen August 27, 2024 13:23
Copy link

codspeed-hq bot commented Aug 27, 2024

CodSpeed Performance Report

Merging #5266 will not alter performance

Comparing 08-27-feat_wasm_output_symbol_ids_in_scope_tree (c23104b) with main (05d25e2)

Summary

✅ 29 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Aug 27, 2024
Copy link

graphite-app bot commented Aug 27, 2024

Merge activity

  • Aug 27, 9:48 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 27, 9:49 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • Aug 27, 9:55 AM EDT: Boshen merged this pull request with the Graphite merge queue.

`oxc_wasm` include `SymbolId`s in print-out of scopes.
@Boshen Boshen force-pushed the 08-27-perf_wasm_generate_scope_text_with_visitor branch from bc32c2e to 6a49dc3 Compare August 27, 2024 13:49
@Boshen Boshen force-pushed the 08-27-feat_wasm_output_symbol_ids_in_scope_tree branch from 7a7731e to c23104b Compare August 27, 2024 13:50
Base automatically changed from 08-27-perf_wasm_generate_scope_text_with_visitor to main August 27, 2024 13:53
@graphite-app graphite-app bot merged commit c23104b into main Aug 27, 2024
24 checks passed
@graphite-app graphite-app bot deleted the 08-27-feat_wasm_output_symbol_ids_in_scope_tree branch August 27, 2024 13:55
eryue0220 added a commit to eryue0220/oxc that referenced this pull request Aug 27, 2024
…o fix/jest-vitest-compat

* 'fix/jest-vitest-compat' of github.com:eryue0220/oxc:
  fix(wasm): reference ast from prettier (oxc-project#5268)
  feat(wasm): output symbol IDs in scope tree (oxc-project#5266)
  perf(wasm): generate scope text with visitor (oxc-project#5264)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants