Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(linter): use cow_utils in no_script_url #5633

Merged
merged 2 commits into from
Sep 9, 2024
Merged

perf(linter): use cow_utils in no_script_url #5633

merged 2 commits into from
Sep 9, 2024

Conversation

heygsc
Copy link
Contributor

@heygsc heygsc commented Sep 9, 2024

part of #5586

I don't know if this is right or not🤣

@graphite-app Graphite App
Copy link

graphite-app bot commented Sep 9, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-linter Area - Linter label Sep 9, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 9, 2024

CodSpeed Performance Report

Merging #5633 will not alter performance

Comparing heygsc:cow_utils (aaad1be) with main (af6d240)

Summary

✅ 29 untouched benchmarks

@DonIsaac DonIsaac self-assigned this Sep 9, 2024
@DonIsaac DonIsaac added the C-performance Category - Solution not expected to change functional behavior, only performance label Sep 9, 2024
DonIsaac
DonIsaac reviewed Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@DonIsaac DonIsaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start! Im sure other PRs will update other parts of the code.

crates/oxc_linter/Cargo.toml Show resolved Hide resolved
@Boshen
Copy link
Member

Boshen commented Sep 9, 2024

This is great! Keep going! You may find inefficient routines while working on this ;-)

@heygsc
Copy link
Contributor Author

heygsc commented Sep 9, 2024 •
edited
Loading

Thank you both. At first, I wasn't sure if it was right, so I didn't try to do more.

Open a new PR? Or should I continue to modify other rules here?

@shulaoda
Copy link
Contributor

shulaoda commented Sep 9, 2024 •
edited
Loading

Open a new PR? Or should I continue to modify other rules here?

I think opening a new PR is better.

@IWANABETHATGUY IWANABETHATGUY added the 0-merge Merge with Graphite Merge Queue label Sep 9, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Sep 9, 2024

Merge activity

  • Sep 9, 2:52 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

@graphite-app Graphite App
Copy link

graphite-app bot commented Sep 9, 2024 •
edited
Loading

Merge activity

  • Sep 9, 2:52 AM EDT: IWANABETHATGUY added this pull request to the Graphite merge queue.
  • Sep 9, 2:52 AM EDT: The Graphite merge queue couldn't merge this PR because it failed for an unknown reason (Stack merges are not currently supported for forked repositories. Please create a branch in the target repository in order to merge).
  • Sep 9, 2:53 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 9, 2:53 AM EDT: The Graphite merge queue couldn't merge this PR because it failed for an unknown reason (Stack merges are not currently supported for forked repositories. Please create a branch in the target repository in order to merge).

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 9, 2024
@IWANABETHATGUY IWANABETHATGUY added the 0-merge Merge with Graphite Merge Queue label Sep 9, 2024 — with Graphite App
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 9, 2024
@Boshen Boshen merged commit a0370bf into oxc-project:main Sep 9, 2024
27 checks passed
@heygsc heygsc deleted the cow_utils branch September 9, 2024 07:07
@oxc-bot oxc-bot mentioned this pull request Sep 12, 2024
Merged
Boshen added a commit that referenced this pull request Sep 12, 2024
@oxc-bot @Boshen @autofix-ci
release(oxlint): v0.9.4 (#5718)
d06bab6 
## [0.9.4] - 2024-09-12

### Features

- 9ca2593 linter: Eslint/sort-keys  (#4845) (Na'aman Hirschfeld)
- 023c160 linter: Impl `Serialize` for `OxlintConfig` (#5594) (DonIsaac)
- 24d6a47 linter: Implement `eslint/no-invalid-regexp` (#5443) (Boshen)

### Bug Fixes

- af6d240 linter: Panic in consistent-function-scoping (#5613)
(DonIsaac)
- 54e2e76 linter: `react/no_set_state` + `react/no_string_refs` rules
find correct parent (#5615) (overlookmotel)
- 3b87ac4 linter: Fix no_unused_vars panic when encountering unicode
(#5582) (Boshen)

### Performance

- bfe9186 linter: Use `cow_replace` instead of `replace` (#5643)
(dalaoshu)
- e3ae5db linter: Use cow_to_ascii_lowercase/uppercase (#5637) (heygsc)
- a0370bf linter: Use cow_utils in no_script_url (#5633) (heygsc)
- 37e922c linter: `eslint/no_shadow_restricted_names` use
`run_on_symbol` (#5618) (overlookmotel)
- 0b7fccf linter: `react/no_set_state` + `react/no_string_refs` rules
reduce iteration over ancestors (#5616) (overlookmotel)
- 2c3f3fe linter: Make `jsx_key` slightly faster (#5585) (Boshen)
- cd81d12 linter: Add `should_run` to check path only once to
nextjs/no_typos (#5584) (Boshen)
- d18c896 rust: Use `cow_utils` instead (#5664) (dalaoshu)

### Documentation

- 64f9575 linter: Add plugin usage to example with configuration
(Boshen)
- 8c9179d linter: Fix typos (#5591) (Brian Donovan)

### Refactor

- 9e9435f linter: Add `LintFilter` (#5685) (DonIsaac)
- 4f70fe5 linter: Start internal/external split of LintPluginOptions
(#5660) (DonIsaac)
- 5ae9b48 linter: Start internal/external split of `OxlintOptions`
(#5659) (DonIsaac)
- c8bc6f0 linter: Use `std::ptr::eq` (#5649) (overlookmotel)
- a37c064 linter: Use `ContentHash` for `no_duplicate_case`; remove
`calculate_hash` (#5648) (Boshen)
- 0b3c1d7 linter: Start internal/external split of `OxlintConfig`
(#5595) (DonIsaac)
- 89bdf55 linter: Inline `Rule` trait default methods (#5619)
(overlookmotel)
- afea8d5 linter: Rename `Rule` trait method params (#5617)
(overlookmotel)
- 4e748b5 linter: Replace ast "compare by hash" to "compare by content"
(#5602) (dalaoshu)
- bac03e3 linter: Make fields of `LintServiceOptions` private (#5593)
(DonIsaac)
- 2661d8b linter: Jest prefer_strict_equal (#5588) (IWANABETHATGUY)
- 20d0068 oxlint: Move cli-related exports to `cli` module (#5139)
(DonIsaac)
- 067f9b5 semantic: Introduce `IsGlobalReference` trait (#5672)
(Boshen)- 26d9235 Enable clippy::ref_as_ptr (#5577) (夕舞八弦)

### Testing

- 8e79f8d linter: Add class method test cases for `oxc/no-async-await`
(#5550) (DonIsaac)
- 3835189 linter: Add test case for no_unused_vars in 3b87ac4 (Boshen)
- 5f27551 linter: Add a passing case to no_undef (#5580) (Boshen)

---------

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
This was referenced Sep 12, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DonIsaac DonIsaac DonIsaac left review comments

@Boshen Boshen Boshen left review comments

@camc314 camc314 camc314 approved these changes

Assignees

@DonIsaac DonIsaac

Labels
A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@heygsc @Boshen @shulaoda @camc314 @DonIsaac @IWANABETHATGUY