Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(linter): forbid string allocation methods such as to_lowercase and replace #5662

Closed
wants to merge 1 commit into from
Closed

refactor(linter): forbid string allocation methods such as to_lowercase and replace #5662

wants to merge 1 commit into from

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Sep 10, 2024 •
edited
Loading

closes #5586

Feel free to use the PR as the base and make changes.

@graphite-app Graphite App
Copy link

graphite-app bot commented Sep 10, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-linter Area - Linter A-prettier Area - Prettier A-ast-tools Area - AST tools labels Sep 10, 2024
@Boshen Boshen mentioned this pull request Sep 10, 2024
Closed
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 10, 2024

CodSpeed Performance Report

Merging #5662 will not alter performance

Comparing disallowed-methods (d254435) with main (0511d55)

Summary

✅ 29 untouched benchmarks

@shulaoda shulaoda mentioned this pull request Sep 10, 2024
Merged
@shulaoda
Copy link
Contributor

I have found that these also exist in some test cases. Should we completely eliminate them?

@Boshen
Copy link
Member Author

Boshen commented Sep 10, 2024

I have found that these also exist in some test cases. Should we completely eliminate them?

Don't bother if there are a lot, otherwise we should make tests a little bit faster as well.

@DonIsaac DonIsaac added the C-performance Category - Solution not expected to change functional behavior, only performance label Sep 10, 2024
Boshen added a commit that referenced this pull request Sep 11, 2024
@shulaoda @Boshen
perf(rust): use cow_utils instead (#5664)
d18c896 
Related to #5586 and #5662

---------

Co-authored-by: Boshen <boshenc@gmail.com>
@Boshen Boshen closed this Sep 11, 2024
@Boshen Boshen deleted the disallowed-methods branch September 11, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DonIsaac DonIsaac DonIsaac approved these changes

Assignees
No one assigned
Labels
A-ast-tools Area - AST tools A-linter Area - Linter A-prettier Area - Prettier C-performance Category - Solution not expected to change functional behavior, only performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

perf(linter): replace string operations with cow_utils::CowUtils
3 participants
@Boshen @shulaoda @DonIsaac