refactor(linter): use regex parser in eslint/no-regex-spaces
#5952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @camchenry and the rest of your teammates on |
DonIsaac
changed the title
eslint/no-regex-spaces
CodSpeed Performance ReportMerging #5952 will not alter performanceComparing Summary
|
camchenry
force-pushed
the
linter/refactor-no-regex-spaces
branch
from
f3fdf77
to
4b53226
Compare
DonIsaac
reviewed
Sep 21, 2024
camchenry
force-pushed
the
linter/refactor-no-regex-spaces
branch
from
4b53226
to
ed7fabd
Compare
camchenry
changed the base branch from
09-21-feat_regular_expression_add_terms_visitor_to_pattern
to
main
|
I moved the visitor method code to be specific to this rule, to avoid the conversation of what a generic regex AST visitor might look like. |
camchenry
force-pushed
the
linter/refactor-no-regex-spaces
branch
from
ed7fabd
to
1a1e436
Compare
DonIsaac
approved these changes
Sep 22, 2024
Merge activity
|
- part of #5416 Use the `oxc_regular_expression` parser to make these checks more robust. a few snapshots are updated because they now output more accurate diagnostics based on the regex AST. for example, `/ ?/` now correctly only highlights two spaces rather than three (because the last one is part of a quantifier)
Boshen
force-pushed
the
linter/refactor-no-regex-spaces
branch
from
1a1e436
to
a9a8e2a
Compare
Boshen
added a commit
that referenced
this pull request
Sep 23, 2024
## [0.9.7] - 2024-09-23 ### Features - d24985e linter: Add `oxc-security/api-keys` (#5906) (DonIsaac) - f9b44c5 linter: Add unicode sets support to `no-useless-escape` rule (#5974) (camchenry) - 0f19848 linter: Implement `no-unexpected-multiline` rule (#5911) (camchenry) - 16fe383 linter: Implement `no-extend-native` rule (#5867) (Cam McHenry) ### Bug Fixes - eed9ac7 linter: Include actual span size in `no-regex-spaces` diagnostic (#5957) (camchenry) - 40c89c2 linter: Move `promise/avoid-new` to style category (#5961) (DonIsaac) ### Performance - 608d637 linter: Use `aho-corasick` instead of `regex` for string matching in `jsx-a11y/img-redundant-alt` (#5892) (camchenry) - 3148d4b linter: Check file path after checking node kind for `nextjs/no-head-element` (#5868) (Cam McHenry) ### Refactor - 0a5a4a9 linter: Use parsed patterns for `unicorn/no-hex-escape` (#5985) (camchenry) - 2cf2edd linter: Use parsed patterns in `no-empty-character-class` rule (#5980) (camchenry) - a9a8e2a linter: Use regex parser in `eslint/no-regex-spaces` (#5952) (camchenry) - 05f592b linter: Use parsed patterns in `unicorn/prefer-string-starts-ends-with` (#5949) (camchenry) - 3273b64 linter: Use parsed patterns for `unicorn/prefer-string-replace-all` rule (#5943) (camchenry) - ba7b01f linter: Add `LinterBuilder` (#5714) (DonIsaac) - db4f16a semantic: Call `with_trivias` before `build_with_jsdoc` (#5875) (Boshen) - 3d13c6d semantic: Impl `IntoIterator` for `&AstNodes` (#5873) (DonIsaac) ### Testing - b681c9a linter: Import test cases for `no-empty-character-class` (#5981) (camchenry) - 767602b linter: Add regression test for #5227 (#5975) (camchenry) --------- Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
oxc_regular_expressionparser to make these checks more robust. a few snapshots are updated because they now output more accurate diagnostics based on the regex AST. for example,/ ?/now correctly only highlights two spaces rather than three (because the last one is part of a quantifier)